This is an archive of the discontinued LLVM Phabricator instance.

[X86] Teach fastisel to select calls to dllimport functions
ClosedPublic

Authored by rnk on Aug 1 2017, 4:00 PM.

Details

Summary

Direct calls to dllimport functions are very common Windows. We should
add them to the -O0 fast path.

Event Timeline

rnk created this revision.Aug 1 2017, 4:00 PM

+more object file / relocation reviewers

echristo accepted this revision.Aug 4 2017, 3:40 PM

In general looks ok. Mind commenting the if(NeedLoad) areas as to what you're adding on and why? The symbol is (IMO) obvious, but the random bits less so.

Thanks!

This revision is now accepted and ready to land.Aug 4 2017, 3:40 PM
This revision was automatically updated to reflect the committed changes.