This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Replace parallelForEach with ranged form.
ClosedPublic

Authored by grimar on Jul 31 2017, 7:16 AM.

Diff Detail

Event Timeline

grimar created this revision.Jul 31 2017, 7:16 AM
ruiu edited edge metadata.Jul 31 2017, 5:26 PM

I'm sort of neutral to this change, so if you prefer this style, go for it.

ELF/Threads.h
70

Why auto?

grimar updated this revision to Diff 109066.Aug 1 2017, 3:23 AM
  • Fixed misprint auto -> void
This revision was automatically updated to reflect the committed changes.
ruiu added a comment.Aug 4 2017, 2:22 AM

I wouldn't request you revert this, but if I were you, I wouldn't have commit this change, because as we discussed, this change contains subtle code that seems only language experts can understand. I don't think it is overall beneficial to save a few lines of code by writing very "smart" code here.