This is an archive of the discontinued LLVM Phabricator instance.

[x86][inline-asm]Allow a pack of Control Debug to be properly picked
ClosedPublic

Authored by coby on Jul 31 2017, 12:57 AM.

Download Raw Diff

Details

Reviewers

rnk
echristo
myatsina

Commits

rGd2bb48f0bdff: [x86][inline-asm]Allow a pack of Control Debug to be properly picked
rC309672: [x86][inline-asm]Allow a pack of Control Debug to be properly picked
rL309672: [x86][inline-asm]Allow a pack of Control Debug to be properly picked

Summary

Allows the incorporation of legit (x86) Debug Regs within inline asm stataements

Diff Detail

Repository: rL LLVM

Event Timeline

coby created this revision.Jul 31 2017, 12:57 AM

Herald added a subscriber: eraman. · View Herald TranscriptJul 31 2017, 12:57 AM

lgtm

This revision is now accepted and ready to land.Jul 31 2017, 11:48 AM

Closed by commit rL309672: [x86][inline-asm]Allow a pack of Control Debug to be properly picked (authored by coby). · Explain WhyAug 1 2017, 3:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Basic/

Targets/

X86.cpp

1 line

test/

CodeGen/

ms-inline-asm.c

13 lines

Diff 108872

lib/Basic/Targets/X86.cpp

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines	static const char *const GCCRegNames[] = {
"ymm18", "ymm19", "ymm20", "ymm21", "ymm22", "ymm23", "ymm24", "ymm25",		"ymm18", "ymm19", "ymm20", "ymm21", "ymm22", "ymm23", "ymm24", "ymm25",
"ymm26", "ymm27", "ymm28", "ymm29", "ymm30", "ymm31", "zmm0", "zmm1",		"ymm26", "ymm27", "ymm28", "ymm29", "ymm30", "ymm31", "zmm0", "zmm1",
"zmm2", "zmm3", "zmm4", "zmm5", "zmm6", "zmm7", "zmm8", "zmm9",		"zmm2", "zmm3", "zmm4", "zmm5", "zmm6", "zmm7", "zmm8", "zmm9",
"zmm10", "zmm11", "zmm12", "zmm13", "zmm14", "zmm15", "zmm16", "zmm17",		"zmm10", "zmm11", "zmm12", "zmm13", "zmm14", "zmm15", "zmm16", "zmm17",
"zmm18", "zmm19", "zmm20", "zmm21", "zmm22", "zmm23", "zmm24", "zmm25",		"zmm18", "zmm19", "zmm20", "zmm21", "zmm22", "zmm23", "zmm24", "zmm25",
"zmm26", "zmm27", "zmm28", "zmm29", "zmm30", "zmm31", "k0", "k1",		"zmm26", "zmm27", "zmm28", "zmm29", "zmm30", "zmm31", "k0", "k1",
"k2", "k3", "k4", "k5", "k6", "k7",		"k2", "k3", "k4", "k5", "k6", "k7",
"cr0", "cr2", "cr3", "cr4", "cr8",		"cr0", "cr2", "cr3", "cr4", "cr8",
		"dr0", "dr1", "dr2", "dr3", "dr6", "dr7",
};		};

const TargetInfo::AddlRegName AddlRegNames[] = {		const TargetInfo::AddlRegName AddlRegNames[] = {
{{"al", "ah", "eax", "rax"}, 0},		{{"al", "ah", "eax", "rax"}, 0},
{{"bl", "bh", "ebx", "rbx"}, 3},		{{"bl", "bh", "ebx", "rbx"}, 3},
{{"cl", "ch", "ecx", "rcx"}, 2},		{{"cl", "ch", "ecx", "rcx"}, 2},
{{"dl", "dh", "edx", "rdx"}, 1},		{{"dl", "dh", "edx", "rdx"}, 1},
{{"esi", "rsi"}, 4},		{{"esi", "rsi"}, 4},
▲ Show 20 Lines • Show All 1,509 Lines • Show Last 20 Lines

test/CodeGen/ms-inline-asm.c

Show First 20 Lines • Show All 632 Lines • ▼ Show 20 Lines	__asm {
mov cr0, eax		mov cr0, eax
mov cr2, ebx		mov cr2, ebx
mov cr3, ecx		mov cr3, ecx
mov cr4, edx		mov cr4, edx
}		}
// CHECK: call void asm sideeffect inteldialect "mov cr0, eax\0A\09mov cr2, ebx\0A\09mov cr3, ecx\0A\09mov cr4, edx", "~{cr0},~{cr2},~{cr3},~{cr4},~{dirflag},~{fpsr},~{flags}"()		// CHECK: call void asm sideeffect inteldialect "mov cr0, eax\0A\09mov cr2, ebx\0A\09mov cr3, ecx\0A\09mov cr4, edx", "~{cr0},~{cr2},~{cr3},~{cr4},~{dirflag},~{fpsr},~{flags}"()
}		}

		void t45() {
		// CHECK-LABEL: define void @t45
		__asm {
		mov dr0, eax
		mov dr1, ebx
		mov dr2, ebx
		mov dr3, ecx
		mov dr6, edx
		mov dr7, ecx
		}
		// CHECK: call void asm sideeffect inteldialect "mov dr0, eax\0A\09mov dr1, ebx\0A\09mov dr2, ebx\0A\09mov dr3, ecx\0A\09mov dr6, edx\0A\09mov dr7, ecx", "~{dr0},~{dr1},~{dr2},~{dr3},~{dr6},~{dr7},~{dirflag},~{fpsr},~{flags}"()
		}

void dot_operator(){		void dot_operator(){
// CHECK-LABEL: define void @dot_operator		// CHECK-LABEL: define void @dot_operator
__asm { mov eax, 3[ebx]A.b}		__asm { mov eax, 3[ebx]A.b}
// CHECK: call void asm sideeffect inteldialect "mov eax, $$3[ebx].4", "~{eax},~{dirflag},~{fpsr},~{flags}"		// CHECK: call void asm sideeffect inteldialect "mov eax, $$3[ebx].4", "~{eax},~{dirflag},~{fpsr},~{flags}"
}		}

void call_clobber() {		void call_clobber() {
__asm call t41		__asm call t41
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines