This is an archive of the discontinued LLVM Phabricator instance.

[x86][inline-asm][ms-compat] legalize the use of "jc/jz short <op>"
ClosedPublic

Authored by coby on Jul 26 2017, 8:18 AM.

Reviewers

Commits

Summary

MS ignores the keyword "short" when used after a jc/jz instruction, LLVM ought to do the same.
Test: D35893

lgtm

This revision is now accepted and ready to land.Jul 26 2017, 10:54 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Target/

X86/

AsmParser/

3 lines

	Show First 20 Lines • Show All 2,303 Lines • ▼ Show 20 Lines
	}			}

	bool X86AsmParser::ParseInstruction(ParseInstructionInfo &Info, StringRef Name,			bool X86AsmParser::ParseInstruction(ParseInstructionInfo &Info, StringRef Name,
	SMLoc NameLoc, OperandVector &Operands) {			SMLoc NameLoc, OperandVector &Operands) {
	MCAsmParser &Parser = getParser();			MCAsmParser &Parser = getParser();
	InstInfo = &Info;			InstInfo = &Info;
	StringRef PatchedName = Name;			StringRef PatchedName = Name;

	if (Name == "jmp" && isParsingIntelSyntax() && isParsingInlineAsm()) {			if ((Name.equals("jmp") \|\| Name.equals("jc") \|\| Name.equals("jz")) &&
				isParsingIntelSyntax() && isParsingInlineAsm()) {
	StringRef NextTok = Parser.getTok().getString();			StringRef NextTok = Parser.getTok().getString();
	if (NextTok == "short") {			if (NextTok == "short") {
	SMLoc NameEndLoc =			SMLoc NameEndLoc =
	NameLoc.getFromPointer(NameLoc.getPointer() + Name.size());			NameLoc.getFromPointer(NameLoc.getPointer() + Name.size());
	// Eat the short keyword			// Eat the short keyword
	Parser.Lex();			Parser.Lex();
	// MS ignores the short keyword, it determines the jmp type based			// MS ignores the short keyword, it determines the jmp type based
	// on the distance of the label			// on the distance of the label
	▲ Show 20 Lines • Show All 944 Lines • Show Last 20 Lines