Page MenuHomePhabricator

Add an empty shell of llvm-rc.

Authored by mnbvmar on Jul 24 2017, 11:50 AM.



This starts the development of llvm-rc, a platform-independent port of Microsoft's rc.exe tool. The current revision includes only command-line arguments parsing.

The shell is similar in its implementation to llvm-cvtres.

Diff Detail


Event Timeline

mnbvmar created this revision.Jul 24 2017, 11:50 AM
ecbeckmann added inline comments.Jul 24 2017, 2:35 PM
1 ↗(On Diff #107929)


15 ↗(On Diff #107929)

I don't think you need this.

mnbvmar updated this revision to Diff 107978.Jul 24 2017, 3:31 PM

Typos fixed.

mnbvmar marked 2 inline comments as done.Jul 24 2017, 3:31 PM
rnk edited edge metadata.Jul 24 2017, 3:32 PM

Minor comment, looks good otherwise.

71–88 ↗(On Diff #107929)

These look unused. Do we need them?

mnbvmar added inline comments.Jul 24 2017, 3:40 PM
71–88 ↗(On Diff #107929)

Indeed, these were taken from cvtres tool and are unnecessary here. I'm going to remove them (and reportError, too).

mnbvmar updated this revision to Diff 107981.Jul 24 2017, 3:46 PM

Removed unnecessary error handling methods.

ecbeckmann accepted this revision.Jul 24 2017, 3:49 PM
This revision is now accepted and ready to land.Jul 24 2017, 3:49 PM
This revision was automatically updated to reflect the committed changes.