Page MenuHomePhabricator

[ELF] - Fix calculation of memory region offset.
ClosedPublic

Authored by grimar on Jul 24 2017, 9:12 AM.

Details

Summary

This is PR33714.

Previously for each input section offset of memory region
was incremented on a size of output section.

That resulted in a wrong error message saying about
overflow. Patch fixes that.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Jul 24 2017, 9:12 AM
grimar edited the summary of this revision. (Show Details)Jul 24 2017, 9:12 AM
meadori edited edge metadata.Jul 24 2017, 9:40 AM

Thanks for fixing this. I had recently ran into as well. LGTM.

ruiu accepted this revision.Jul 24 2017, 9:51 AM

LGTM

This revision is now accepted and ready to land.Jul 24 2017, 9:51 AM
This revision was automatically updated to reflect the committed changes.