Page MenuHomePhabricator

meadori (Meador Inge)
Sourcerer

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 3:36 PM (361 w, 2 d)

Recent Activity

Oct 3 2017

meadori added a comment to D38416: [RFC] Add a LIT-style Progress Bar to libSupport.

Is this something that would be useful upstream?

Oct 3 2017, 9:29 AM

Aug 8 2017

meadori added a comment to D36451: [ELF, LinkerScript] Support ! operator in linker script..

Outside the comments @grimar made, LGTM.

Aug 8 2017, 7:51 AM

Aug 6 2017

meadori committed rL310200: [AVR] Compute code model if one is not provided.
[AVR] Compute code model if one is not provided
Aug 6 2017, 5:03 AM

Jul 26 2017

meadori committed rL309191: [ELF, LinkerScript] Memory region name parsing fix.
[ELF, LinkerScript] Memory region name parsing fix
Jul 26 2017, 2:53 PM
meadori closed D35920: [ELF, LinkerScript] Memory region name parsing fix by committing rL309191: [ELF, LinkerScript] Memory region name parsing fix.
Jul 26 2017, 2:53 PM
meadori updated the summary of D35920: [ELF, LinkerScript] Memory region name parsing fix.
Jul 26 2017, 2:48 PM
meadori created D35920: [ELF, LinkerScript] Memory region name parsing fix.
Jul 26 2017, 2:44 PM

Jul 24 2017

meadori added a comment to D35803: [ELF] - Fix calculation of memory region offset..

Thanks for fixing this. I had recently ran into as well. LGTM.

Jul 24 2017, 9:42 AM

Jun 23 2017

meadori accepted D34551: [AVR] Migrate to new MCAsmBackend applyFixup and processFixupValue.

LGTM.

Jun 23 2017, 9:31 AM
meadori added a comment to D34554: [ELF] FIx use-after-return of archive path .

Test case?

Jun 23 2017, 8:10 AM · lld

Jun 20 2017

meadori added a comment to D34391: [RegisterCoalescer] Fix for SubRange join unreachable.

Test case?

Jun 20 2017, 5:37 AM

Jun 16 2017

meadori added a comment to D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started.

Seeing how things grow and de-duplicating as necessary seems like a reasonable strategy to me.

Jun 16 2017, 2:46 PM
meadori added a comment to D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started.

Okay, that makes sense. Thanks to all that explained it.

Jun 16 2017, 1:55 PM

Jun 15 2017

meadori added a comment to D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started.

I having looked through the fine details yet, but one higher level question: I saw the discussions on the mailing list concerning being careful not to go overboard making everything work with multiple object file formats and to start with ELF. That being said, why can't just the ELF functionality of libObject be extended to write? Seems like going that way would make it easier for others to reuse in other tools.

Jun 15 2017, 10:29 AM
meadori added a comment to D34220: [AArch64] Prefer B.cond to CBZ/CBNZ/TBZ/TBNZ when NZCV flags can be set for "free".

RE: the feature flag statement. Unless we know that this is a win all supported sub-targets (micro-architectures), then it seems like a feature flag would be the way to go, right?

Jun 15 2017, 10:05 AM

Apr 5 2017

meadori committed rL299597: [Driver] Print a newline when invoking `-print-resource-dir`.
[Driver] Print a newline when invoking `-print-resource-dir`
Apr 5 2017, 3:39 PM

Apr 4 2017

meadori committed rL299473: [Driver] Add option to print the resource directory.
[Driver] Add option to print the resource directory
Apr 4 2017, 2:59 PM
meadori closed D31447: [Driver] Add option to print the resource directory by committing rL299473: [Driver] Add option to print the resource directory.
Apr 4 2017, 2:59 PM

Mar 23 2017

meadori committed rL298677: [AVR] Fix build after r298178.
[AVR] Fix build after r298178
Mar 23 2017, 7:09 PM

Jan 23 2017

meadori committed rL292875: [LinkerScript] Implement `MEMORY` command.
[LinkerScript] Implement `MEMORY` command
Jan 23 2017, 6:45 PM
meadori closed D28911: [LinkerScript] Implement `MEMORY` command by committing rL292875: [LinkerScript] Implement `MEMORY` command.
Jan 23 2017, 6:45 PM
meadori added a comment to D28911: [LinkerScript] Implement `MEMORY` command.

I will fix the remaining nits and double-check with gold\ld. Thanks for all the review!

Jan 23 2017, 6:15 PM
meadori updated the diff for D28911: [LinkerScript] Implement `MEMORY` command.
  1. Shorten overflow error message.
  2. Get rid of MemoryRegion constructors.
  3. A few more style changes.
Jan 23 2017, 5:14 PM
meadori added inline comments to D28911: [LinkerScript] Implement `MEMORY` command.
Jan 23 2017, 4:58 PM
meadori added inline comments to D28911: [LinkerScript] Implement `MEMORY` command.
Jan 23 2017, 2:28 PM
meadori updated the diff for D28911: [LinkerScript] Implement `MEMORY` command.

Address more style comments from review feedback.

Jan 23 2017, 8:56 AM
meadori added inline comments to D28911: [LinkerScript] Implement `MEMORY` command.
Jan 23 2017, 8:22 AM

Jan 21 2017

meadori updated the diff for D28911: [LinkerScript] Implement `MEMORY` command.

Address review feedback concerning code style and comments.

Jan 21 2017, 5:08 PM
meadori added inline comments to D28911: [LinkerScript] Implement `MEMORY` command.
Jan 21 2017, 4:46 PM
meadori updated the diff for D28911: [LinkerScript] Implement `MEMORY` command.
  1. Finished attribute implementation.
Jan 21 2017, 11:10 AM
meadori added inline comments to D28911: [LinkerScript] Implement `MEMORY` command.
Jan 21 2017, 10:52 AM

Jan 19 2017

meadori created D28911: [LinkerScript] Implement `MEMORY` command.
Jan 19 2017, 12:14 PM
meadori added a comment to D28903: [ELF] - Do not crash when assign common symbol's values in script.

IIUC, the crash is b/c LinkerScript<ELFT>::getSymbolSection has no code to handle the common symbol case. The fix is to use SymbolTableSection<ELFT>::getOutputSection, which does have code for handling commons (and various other kinds). If so, then LGTM.

Jan 19 2017, 8:29 AM

Jan 9 2017

meadori committed rL291501: [ELF] Fix `_gp` linker script test.
[ELF] Fix `_gp` linker script test
Jan 9 2017, 3:27 PM
meadori closed D27276: [ELF] Allow defined symbols to be assigned from linker script.

Committed. Thanks for all the review @ruiu. Much appreciated.

Jan 9 2017, 10:50 AM
meadori committed rL291459: [ELF] Allow defined symbols to be assigned from linker script.
[ELF] Allow defined symbols to be assigned from linker script
Jan 9 2017, 10:47 AM

Jan 6 2017

meadori updated the diff for D27276: [ELF] Allow defined symbols to be assigned from linker script.
  • Address @ruiu's point about using addUndefined. Note that I had to use the long form to control the visibility (for symbols defined in PROVIDE).
  • XFAIL of test/ELF/mips-gp-ext.s remains -- this test fails now due to another lld bug. I will look into the other bug after pushing this through.
Jan 6 2017, 11:14 AM
meadori added inline comments to D27276: [ELF] Allow defined symbols to be assigned from linker script.
Jan 6 2017, 11:12 AM

Jan 5 2017

meadori updated the diff for D27276: [ELF] Allow defined symbols to be assigned from linker script.
  • Address @ruiu's point about using replaceBody.
  • Add XFAIL back to test/ELF/mips-gp-ext.s -- this test fails now due to another lld bug. I will look into the other bug after pushing this through.
Jan 5 2017, 7:58 PM
meadori added inline comments to D27276: [ELF] Allow defined symbols to be assigned from linker script.
Jan 5 2017, 7:55 PM

Jan 3 2017

meadori updated the diff for D27276: [ELF] Allow defined symbols to be assigned from linker script.

Apologies for the delay on this one. @ruiu, if I understand correctly you are suggesting for the unconditional replacement of the symbols in the symbol table. That make sense to me. The latest patch adds a "force create" option to the appropriate symbol table methods. Is that okay?

Jan 3 2017, 2:13 PM

Dec 18 2016

meadori added a comment to D27276: [ELF] Allow defined symbols to be assigned from linker script.

I'm concerned a bit about the XFAIL mips test. Do you have any estimations when this patch be ready?

Dec 18 2016, 6:35 PM

Dec 9 2016

meadori added a comment to D27561: [ELF] Allow output section data commands to take expressions.

@grimar , you are right. The tests lines should be reworked. Thinko on my part. Fixed in r289278. Thanks for pointing this out!

Dec 9 2016, 2:02 PM
meadori committed rL289278: [ELF] Fix test case thinko from r289152.
[ELF] Fix test case thinko from r289152
Dec 9 2016, 2:01 PM
meadori committed rL289152: [ELF] Allow output section data commands to take expressions.
[ELF] Allow output section data commands to take expressions
Dec 9 2016, 4:01 AM
meadori closed D27561: [ELF] Allow output section data commands to take expressions by committing rL289152: [ELF] Allow output section data commands to take expressions.
Dec 9 2016, 4:01 AM

Dec 8 2016

meadori added inline comments to D27276: [ELF] Allow defined symbols to be assigned from linker script.
Dec 8 2016, 3:29 PM
meadori updated the diff for D27561: [ELF] Allow output section data commands to take expressions.

Address review feedback.

Dec 8 2016, 3:21 PM
meadori added inline comments to D27276: [ELF] Allow defined symbols to be assigned from linker script.
Dec 8 2016, 3:05 PM
meadori added a comment to D27561: [ELF] Allow output section data commands to take expressions.

Any comments on this one?

Dec 8 2016, 2:45 PM
meadori updated the diff for D27276: [ELF] Allow defined symbols to be assigned from linker script.

Address review feedback:

Dec 8 2016, 2:42 PM
meadori updated the diff for D27276: [ELF] Allow defined symbols to be assigned from linker script.
  • Added a few more comments.
  • Added test cases.
Dec 8 2016, 12:36 PM

Dec 7 2016

meadori retitled D27561: [ELF] Allow output section data commands to take expressions from to [ELF] Allow output section data commands to take expressions.
Dec 7 2016, 6:24 PM
meadori added a comment to D27276: [ELF] Allow defined symbols to be assigned from linker script.
In D27276#616083, @ruiu wrote:

What is the status of this patch? Is this ready for review?

Dec 7 2016, 11:43 AM
meadori added a comment to D27524: [ELF][MIPS] Make _gp, _gp_disp, __gnu_local_gp global symbols.

Other than the one question above, LGTM. I tested this patch with my WIP patch for D27276. Thank you for fixing this.

Dec 7 2016, 11:40 AM · lld
meadori added a comment to D27276: [ELF] Allow defined symbols to be assigned from linker script.

FYI

I fixed the problem with _gp symbol in the D27524.

Dec 7 2016, 8:27 AM

Dec 6 2016

meadori committed rL288843: [llgo] Remove support for LLVM attributes.
[llgo] Remove support for LLVM attributes
Dec 6 2016, 11:32 AM
meadori closed D27474: [llgo] Remove support for LLVM attributes by committing rL288843: [llgo] Remove support for LLVM attributes.
Dec 6 2016, 11:32 AM
meadori retitled D27474: [llgo] Remove support for LLVM attributes from to [llgo] Remove support for LLVM attributes.
Dec 6 2016, 11:04 AM
meadori closed D27441: [llgo] Fix `debug` to use latest `DIBuilder` bindings.

Fixed in rL288768.

Dec 6 2016, 10:48 AM
meadori closed D27442: [llgo] Update to use the latest IR attribute bindings.

Fixed in rL288769.

Dec 6 2016, 10:47 AM

Dec 5 2016

meadori committed rL288769: [llgo] Update to use the latest IR attribute bindings.
[llgo] Update to use the latest IR attribute bindings
Dec 5 2016, 8:11 PM
meadori committed rL288768: [llgo] Fix `debug` to use latest `DIBuilder` bindings.
[llgo] Fix `debug` to use latest `DIBuilder` bindings
Dec 5 2016, 8:10 PM
meadori updated the diff for D27442: [llgo] Update to use the latest IR attribute bindings.

Address review feedback about constraining LLVM attribute application.

Dec 5 2016, 7:07 PM
meadori added inline comments to D27442: [llgo] Update to use the latest IR attribute bindings.
Dec 5 2016, 6:49 PM
meadori added a comment to D22905: [llgo] set debuglocs for calls in synthetic functions.

Would someone mind committing this?
(I am happy to do so myself if no one has the cycles.)

Dec 5 2016, 6:04 PM
meadori retitled D27442: [llgo] Update to use the latest IR attribute bindings from to [llgo] Update to use the latest IR attribute bindings.
Dec 5 2016, 6:02 PM
meadori retitled D27441: [llgo] Fix `debug` to use latest `DIBuilder` bindings from to [llgo] Fix `debug` to use latest `DIBuilder` bindings.
Dec 5 2016, 6:00 PM

Dec 2 2016

meadori added a comment to D26367: Fix DAGCombiner match.

I'm not sure what is "the test-suite".

Dec 2 2016, 11:40 AM
meadori added a comment to D27308: ELF/AArch64: Fix R_AARCH64_LDST16_ABS_LO12_NC mask.

LGTM. It is constant with my understanding of: http://infocenter.arm.com/help/topic/com.arm.doc.ihi0056b/IHI0056B_aaelf64.pdf

Dec 2 2016, 11:02 AM · lld

Nov 30 2016

meadori added a comment to D27276: [ELF] Allow defined symbols to be assigned from linker script.

I want to be able to override *any* symbol's value (which is support in GNUnLD, for example). Currently LLD issues multiple definition errors if I say something like:

Nov 30 2016, 1:53 PM
meadori retitled D27276: [ELF] Allow defined symbols to be assigned from linker script from to [ELF, WIP] Allow defined symbols to be assigned from linker script.
Nov 30 2016, 11:52 AM

Nov 23 2016

meadori committed rL287803: llvm-nm: Print correct symbol types for init and fini sections.
llvm-nm: Print correct symbol types for init and fini sections
Nov 23 2016, 12:27 PM
meadori committed rL287802: llvm-nm: Don't print value or size for undefined or weak symbols.
llvm-nm: Don't print value or size for undefined or weak symbols
Nov 23 2016, 12:27 PM
meadori closed D26937: llvm-nm: Print correct symbol types for init and fini sections by committing rL287803: llvm-nm: Print correct symbol types for init and fini sections.
Nov 23 2016, 12:27 PM · Restricted Project
meadori closed D26936: llvm-nm: Don't print value or size for undefined or weak symbols by committing rL287802: llvm-nm: Don't print value or size for undefined or weak symbols.
Nov 23 2016, 12:27 PM

Nov 22 2016

meadori committed rL287677: [ELF] Allow `ASSERT` in output section descriptions.
[ELF] Allow `ASSERT` in output section descriptions
Nov 22 2016, 11:05 AM
meadori closed D26935: [ELF] Allow `ASSERT` in output section descriptions.

Committed. Thanks for the review Rui.

Nov 22 2016, 10:53 AM
meadori added inline comments to D26935: [ELF] Allow `ASSERT` in output section descriptions.
Nov 22 2016, 9:02 AM
meadori updated the diff for D26935: [ELF] Allow `ASSERT` in output section descriptions.

Address review feedback.

Nov 22 2016, 8:49 AM
meadori added inline comments to D26935: [ELF] Allow `ASSERT` in output section descriptions.
Nov 22 2016, 8:28 AM

Nov 21 2016

meadori retitled D26937: llvm-nm: Print correct symbol types for init and fini sections from to llvm-nm: Print correct symbol types for init and fini sections.
Nov 21 2016, 2:09 PM · Restricted Project
meadori retitled D26936: llvm-nm: Don't print value or size for undefined or weak symbols from to llvm-nm: Don't print value or size for undefined or weak symbols.
Nov 21 2016, 2:08 PM
meadori added a reviewer for D26935: [ELF] Allow `ASSERT` in output section descriptions: llvm-commits.
Nov 21 2016, 2:05 PM
meadori retitled D26935: [ELF] Allow `ASSERT` in output section descriptions from to [ELF] Allow `ASSERT` in output section descriptions.
Nov 21 2016, 2:04 PM

Jun 28 2016

meadori added a comment to D21728: [AARCH64] Add Broadcom Vulcan scheduling model.

This looks good to me too.

Jun 28 2016, 3:20 PM

Jun 2 2016

meadori committed rL271574: [ASMParser] Parse FP constants in non-C locales.
[ASMParser] Parse FP constants in non-C locales
Jun 2 2016, 1:11 PM
meadori closed D15375: Fix PR #25788: parsing of floating-point constants on non-C locales by committing rL271574: [ASMParser] Parse FP constants in non-C locales.
Jun 2 2016, 1:11 PM
meadori added a comment to D15375: Fix PR #25788: parsing of floating-point constants on non-C locales.

Do you have commit rights?

Jun 2 2016, 9:30 AM

May 16 2016

meadori added a comment to D20192: [Sema] Fix bug to do with lookup of template friend function in namespace.

Hmmm, it works on trunk r269671. Not sure what happened before.

May 16 2016, 11:41 AM
meadori added a comment to D20192: [Sema] Fix bug to do with lookup of template friend function in namespace.

I see failure when running the Clang test suite with this patch:

May 16 2016, 9:27 AM

Apr 5 2016

meadori added a comment to D18793: fix for 19986, extra spacing around c++14 lambda capture with initializer.

This needs a test case.

Apr 5 2016, 8:40 AM

Mar 2 2016

meadori added a comment to D17609: [lit] Enqueue tests on a separate thread to not hit limits on parallel queues.

I can't speak for the technical changes in this patch, but I will say that I too was experiencing a deadlock on OS X and this patch fixes the problem.

Mar 2 2016, 10:38 AM

Nov 26 2015

meadori added a comment to D14300: MSP430 calling convention updates.

This patch looks good to me with respect to the MSP430 ABI. I did find one other change that needs to be made. Now that R11 is not preserved by the callee it should be marked as clobbered by the call instructions:

Nov 26 2015, 7:29 AM

Nov 25 2015

meadori added a comment to D14300: MSP430 calling convention updates.

Is the ABI documented somewhere public?

Nov 25 2015, 5:36 AM

Nov 24 2015

meadori added inline comments to D14902: [AArch64] Promote loads from stored.
Nov 24 2015, 10:04 AM

Nov 20 2015

meadori added inline comments to D14721: patch for missed constantFold optimization in InstCombine.
Nov 20 2015, 11:47 AM
meadori added a comment to D14755: Handle ARMv6-J as an alias, instead of fake architecture.

It is my understanding as well that -march=armv6 and -march=armv6j are treated the same code gen wise by GCC. However, they do cause different builtin macro to be defined. For example:

Nov 20 2015, 10:37 AM

Nov 2 2015

meadori added a comment to D14234: [ARM] Recognize bit-reversal idioms.

I haven't worked through all the logic yet, but this seems like a very specific optimization. How often have you found that it fires in practice? Any benchmark results?

Nov 2 2015, 8:26 AM

Sep 8 2015

meadori added inline comments to D12692: LLVM does not distinguish Cortex-M4 from Cortex-M4F neither Cortex-R5 from R5F.
Sep 8 2015, 9:54 AM