This is an archive of the discontinued LLVM Phabricator instance.

Differential D35705

[CMake] Use ABI version 2 for C++ library in Fuchsia
ClosedPublic

Authored by phosek on Jul 20 2017, 4:14 PM.

Details

Reviewers
mcgrathr
Commits
rG0f874d4ba5cb: [CMake] Use ABI version 2 for C++ library in Fuchsia
rC308705: [CMake] Use ABI version 2 for C++ library in Fuchsia
rL308705: [CMake] Use ABI version 2 for C++ library in Fuchsia
Summary

Fuchsia has always been using ABI version 2 but I forgot this option when setting up the cache file for runtimes build.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Jul 20 2017, 4:14 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 20 2017, 4:14 PM
mcgrathr accepted this revision.Jul 20 2017, 4:34 PM

LGTM

This revision is now accepted and ready to land.Jul 20 2017, 4:34 PM
phosek retitled this revision from [CMake] Use ABI version 2 for C++ library to [CMake] Use ABI version 2 for C++ library in Fuchsia.Jul 20 2017, 4:35 PM
phosek edited the summary of this revision. (Show Details)
Closed by commit rL308705: [CMake] Use ABI version 2 for C++ library in Fuchsia (authored by phosek). · Explain WhyJul 20 2017, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
caches/
1 line

Diff 107600

cmake/caches/Fuchsia-stage2.cmake

Show All 40 Linesforeach(target x86_64;aarch64)
set(RUNTIMES_${target}-fuchsia_CMAKE_SYSROOT ${FUCHSIA_${target}_SYSROOT} CACHE PATH "") set(RUNTIMES_${target}-fuchsia_CMAKE_SYSROOT ${FUCHSIA_${target}_SYSROOT} CACHE PATH "")
set(RUNTIMES_${target}-fuchsia_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "") set(RUNTIMES_${target}-fuchsia_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "")
set(RUNTIMES_${target}-fuchsia_UNIX 1 CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_UNIX 1 CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LLVM_ENABLE_LIBCXX ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LLVM_ENABLE_LIBCXX ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBUNWIND_USE_COMPILER_RT ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_COMPILER_RT ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXXABI_USE_LLVM_UNWINDER ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "") set(RUNTIMES_${target}-fuchsia_LIBCXX_USE_COMPILER_RT ON CACHE BOOL "")
set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "")
endforeach() endforeach()
# Setup toolchain. # Setup toolchain.
set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "") set(LLVM_INSTALL_TOOLCHAIN_ONLY ON CACHE BOOL "")
set(LLVM_TOOLCHAIN_TOOLS set(LLVM_TOOLCHAIN_TOOLS
llc llc
llvm-ar llvm-ar
llvm-cov llvm-cov
Show All 29 Lines