Page MenuHomePhabricator

[PEI] Add basic opt-remarks support
ClosedPublic

Authored by thegameg on Jul 19 2017, 2:12 PM.

Details

Reviewers
MatzeB
anemet
Summary

Add optimization remarks support to PrologueEpilogueInserter. For now, emit the stack size as an analysis remark, but more additions wrt shrink-wrapping may be added.

Diff Detail

Event Timeline

thegameg created this revision.Jul 19 2017, 2:12 PM
anemet edited edge metadata.Jul 19 2017, 2:16 PM

Looks good, how hard would be to add a test for this?

thegameg updated this revision to Diff 107388.Jul 19 2017, 2:46 PM

Added MIR tests for both AArch64 and X86.

anemet accepted this revision.Jul 19 2017, 2:51 PM

I am not really familiar with MIR test files but this looks straight-forward. LGTM.

This revision is now accepted and ready to land.Jul 19 2017, 2:51 PM
fhahn added a comment.Jul 19 2017, 2:52 PM

Would it be possible to inlcude the full context the remarks, using YAML, e.g. as in D35122?

thegameg updated this revision to Diff 107394.Jul 19 2017, 3:03 PM

Included the full YAML in the test cases.

thegameg closed this revision.Jul 19 2017, 4:52 PM

Committed in r308556: [PEI] Add basic opt-remarks support.