This is an archive of the discontinued LLVM Phabricator instance.

Differential D35641

Fix update_llc_test_checks.py ARM parsing
ClosedPublic

Authored by jgalenson on Jul 19 2017, 1:34 PM.

Download Raw Diff

Details

Reviewers

efriedma

Commits

rGb6fc8dc5e592: Fix update_llc_test_checks.py ARM parsing
rL309457: Fix update_llc_test_checks.py ARM parsing

Summary

When I tried running the script, the ARM regex parser could not parse my code. It failed because the .Lfunc_end line has a comment at the end of it, so this commit removes the newline at the end of the regex.

Diff Detail

Event Timeline

jgalenson created this revision.Jul 19 2017, 1:34 PM

Herald added subscribers: kristof.beyls, aemerson. · View Herald TranscriptJul 19 2017, 1:34 PM

LGTM

This revision is now accepted and ready to land.Jul 21 2017, 4:06 PM

Thanks! Could you commit this for me?

Closed by commit rL309457: Fix update_llc_test_checks.py ARM parsing (authored by efriedma). · Explain WhyJul 28 2017, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

utils/

update_llc_test_checks.py

2 lines

Diff 107364

utils/update_llc_test_checks.py

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	SCRUB_X86_SP_RE = re.compile(r'\d+$%(esp\|rsp)$')			SCRUB_X86_SP_RE = re.compile(r'\d+$%(esp\|rsp)$')
	SCRUB_X86_RIP_RE = re.compile(r'[.\w]+$%rip$')			SCRUB_X86_RIP_RE = re.compile(r'[.\w]+$%rip$')
	SCRUB_X86_LCP_RE = re.compile(r'\.LCPI[0-9]+_[0-9]+')			SCRUB_X86_LCP_RE = re.compile(r'\.LCPI[0-9]+_[0-9]+')

	ASM_FUNCTION_ARM_RE = re.compile(			ASM_FUNCTION_ARM_RE = re.compile(
	r'^(?P<func>[0-9a-zA-Z_]+):\n' # f: (name of function)			r'^(?P<func>[0-9a-zA-Z_]+):\n' # f: (name of function)
	r'\s+\.fnstart\n' # .fnstart			r'\s+\.fnstart\n' # .fnstart
	r'(?P<body>.*?)\n' # (body of the function)			r'(?P<body>.*?)\n' # (body of the function)
	r'.Lfunc_end[0-9]+:\n', # .Lfunc_end0:			r'.Lfunc_end[0-9]+:', # .Lfunc_end0:
	flags=(re.M \| re.S))			flags=(re.M \| re.S))

	RUN_LINE_RE = re.compile('^\s;\sRUN:\s(.)$')			RUN_LINE_RE = re.compile('^\s;\sRUN:\s(.)$')
	TRIPLE_ARG_RE = re.compile(r'-mtriple=([^ ]+)')			TRIPLE_ARG_RE = re.compile(r'-mtriple=([^ ]+)')
	TRIPLE_IR_RE = re.compile(r'^target\s+triple\s=\s"([^"]+)"$')			TRIPLE_IR_RE = re.compile(r'^target\s+triple\s=\s"([^"]+)"$')
	IR_FUNCTION_RE = re.compile('^\sdefine\s+(?:internal\s+)?[^@]@(\w+)\s*\(')			IR_FUNCTION_RE = re.compile('^\sdefine\s+(?:internal\s+)?[^@]@(\w+)\s*\(')
	CHECK_PREFIX_RE = re.compile('--?check-prefix(?:es)?=(\S+)')			CHECK_PREFIX_RE = re.compile('--?check-prefix(?:es)?=(\S+)')
	CHECK_RE = re.compile(r'^\s;\s([^:]+?)(?:-NEXT\|-NOT\|-DAG\|-LABEL)?:')			CHECK_RE = re.compile(r'^\s;\s([^:]+?)(?:-NEXT\|-NOT\|-DAG\|-LABEL)?:')
	▲ Show 20 Lines • Show All 310 Lines • Show Last 20 Lines