This is an archive of the discontinued LLVM Phabricator instance.

Don't set TUScope to null when generating a module in incremental processing mode.
ClosedPublic

Authored by teemperor on Jul 18 2017, 3:05 AM.

Details

Summary

When in incremental processing mode, we should never set TUScope to a nullptr otherwise any future lookups fail. We already have similar checks in the rest of the code, but we never hit this one because so far we didn't try to generate a module from the AST that Cling generates.

Diff Detail

Event Timeline

teemperor created this revision.Jul 18 2017, 3:05 AM
teemperor updated this revision to Diff 107065.Jul 18 2017, 4:55 AM
teemperor edited the summary of this revision. (Show Details)Jul 18 2017, 5:04 AM
teemperor added a reviewer: rsmith.
teemperor added subscribers: v.g.vassilev, cfe-commits.
v.g.vassilev accepted this revision.Jul 18 2017, 5:40 AM

I think we can rely on a post-commit review here. LGTM!

This revision is now accepted and ready to land.Jul 18 2017, 5:40 AM
teemperor closed this revision.Jul 18 2017, 11:25 AM