[mips] Support `long_call/far/near` attributes passed by front-end

[atanasyan]

Summary

This patch adds handling of the long_call, far, and near attributes passed by front-end. The patch depends on D35479.

[sdardis]

Some minor nits. Also, see my question inline.

lib/Target/Mips/MipsISelLowering.cpp

3156

Restore the comment from lines 3156-3157 to an appropriate place.

Question (I haven't looked throughly yet): Can an ExternalSymbolSDNode have the long-call/near-call attribute?

If it can, then this expansion code is missing the portions that check the attributes of the ExternalSymbolSDNode.

test/CodeGen/Mips/long-call-attr.ll

6

Also requires testing for mips64.

16

; CHECK-LABEL: foo: before this.

[atanasyan]

lib/Target/Mips/MipsISelLowering.cpp

3156

Can an ExternalSymbolSDNode have the long-call/near-call attribute?

As far as I understand the IR, ExternalSymbolSDNode cannot contains any attribute.

[atanasyan]

• Addressed review comments: add 64-bit tests, restore comment in the code.

[sdardis]

LGTM.

[atanasyan]

Closed by commit rL308606

lib/Target/Mips/MipsISelLowering.cpp

MipsTargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI,
 
   SDValue CalleeLo;
   EVT Ty = Callee.getValueType();
   bool GlobalOrExternal = false, IsCallReloc = false;
 
   // The long-calls feature is ignored in case of PIC.
   // While we do not support -mshared / -mno-shared properly,
   // ignore long-calls in case of -mabicalls too.
-  if (Subtarget.useLongCalls() && !Subtarget.isABICalls() && !IsPIC) {
-    // Get the address of the callee into a register to prevent
-    // using of the `jal` instruction for the direct call.
-    if (auto *N = dyn_cast<GlobalAddressSDNode>(Callee))
-      Callee = Subtarget.hasSym32() ? getAddrNonPIC(N, SDLoc(N), Ty, DAG)
-                                    : getAddrNonPICSym64(N, SDLoc(N), Ty, DAG);
-    else if (auto *N = dyn_cast<ExternalSymbolSDNode>(Callee))
-      Callee = Subtarget.hasSym32() ? getAddrNonPIC(N, SDLoc(N), Ty, DAG)
-                                    : getAddrNonPICSym64(N, SDLoc(N), Ty, DAG);
+  if (!Subtarget.isABICalls() && !IsPIC) {
+    // If the function should be called using "long call",
+    // get its address into a register to prevent using
+    // of the `jal` instruction for the direct call.
+    if (auto *N = dyn_cast<ExternalSymbolSDNode>(Callee)) {
+      if (Subtarget.useLongCalls())
+        Callee = Subtarget.hasSym32()
+                     ? getAddrNonPIC(N, SDLoc(N), Ty, DAG)
+    } else if (auto *N = dyn_cast<GlobalAddressSDNode>(Callee)) {
+      bool UseLongCalls = Subtarget.useLongCalls();
+      // If the function has long-call/far/near attribute
+      // it overrides command line switch pased to the backend.
+      if (auto *F = dyn_cast<Function>(N->getGlobal())) {
+        if (F->hasFnAttribute("long-call"))
+          UseLongCalls = true;
+        else if (F->hasFnAttribute("short-call"))
+          UseLongCalls = false;
+      }
+      if (UseLongCalls)
+        Callee = Subtarget.hasSym32()
+                     ? getAddrNonPIC(N, SDLoc(N), Ty, DAG)
     }
+  }
 
   if (GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee)) {
     if (IsPIC) {
       const GlobalValue *Val = G->getGlobal();
       InternalLinkage = Val->hasInternalLinkage();
 
       if (InternalLinkage)
         Callee = getAddrLocal(G, DL, Ty, DAG, ABI.IsN32() || ABI.IsN64());

test/CodeGen/Mips/long-call-attr.ll

+; RUN: llc -march=mips -target-abi o32 --mattr=+long-calls,+noabicalls < %s \
+; RUN:   | FileCheck -check-prefix=O32 %s
+; RUN: llc -march=mips -target-abi o32 --mattr=-long-calls,+noabicalls < %s \
+; RUN:   | FileCheck -check-prefix=O32 %s
+; RUN: llc -march=mips64 -target-abi n64 --mattr=+long-calls,+noabicalls < %s \
+; RUN:   | FileCheck -check-prefix=N64 %s
+; RUN: llc -march=mips64 -target-abi n64 --mattr=-long-calls,+noabicalls < %s \
+; RUN:   | FileCheck -check-prefix=N64 %s
+
+declare void @far() #0
+
+define void @near() #1 {
+  ret void
+}
+
+define void @foo() {
+  call void @far()
+
+; O32-LABEL: foo:
+; O32:         lui     $1, %hi(far)
+; O32-NEXT:    addiu   $25, $1, %lo(far)
+; O32-NEXT:    jalr    $25
+
+; N64-LABEL: foo:
+; N64:         lui     $1, %highest(far)
+; N64-NEXT:    daddiu  $1, $1, %higher(far)
+; N64-NEXT:    dsll    $1, $1, 16
+; N64-NEXT:    daddiu  $1, $1, %hi(far)
+; N64-NEXT:    dsll    $1, $1, 16
+; N64-NEXT:    daddiu  $25, $1, %lo(far)
+; N64-NEXT:    jalr    $25
+
+  call void @near()
+
+; O32:         jal near
+; N64:         jal near
+
+  ret void
+}
+
+attributes #0 = { "long-call" }
+attributes #1 = { "short-call" }