Details
Details
- Reviewers
grosser Meinersbur bollu
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Hi Nandini,
this looks very good. Here some feedback regarding your questions.
Best,
Tobias
lib/Transform/Simplify.cpp | ||
---|---|---|
310 | Should not be needed any more after r308152, |
Comment Actions
And one more:
lib/Support/SCEVAffinator.cpp | ||
---|---|---|
138 | I would try to pass the domain of BB rather than BB itself to getPwAff. You likely need to change a couple of the getPwAff declarations (there are various variants). I suggest to do this in a separate patch, similar to how I committed 308152. |
No idea how to pass DomainMap here.