[Solaris] gcc runtime dropped support for .ctors, switch to .init_array

[fedor.sergeev]

Summary

crtbegin.o from gcc toolchain as configured on latest Solaris
(with --enable-initfini-array) does not have support for .ctors.

Clang needs to switch to .init_array. Doing it unconditionally
is fine since older Solaris configurations do support .init_array.

[fedor.sergeev]

Note, that LLVM has already been changed to honor use-init-array on Solaris:

https://reviews.llvm.org/rL305948

(before that change setting Options.UseInitArray in clang would not matter).

[fedor.sergeev]

Added Solaris targets to clang driver test checking for -fuse-init-array.

[aaron.ballman]

This looks reasonable to me, but I am not overly familiar with this part of the toolchain. You should wait for another LG before committing.

[davide]

LGTM.

lib/Driver/ToolChains/Gnu.cpp

2467

this is really a mess.

[fedor.sergeev]

lib/Driver/ToolChains/Gnu.cpp

2467

Any suggestions on how to improve? :)

[dlj]

I think this change is structurally fine, but I'll defer to others on whether it's actually doing the right thing. (I'm pretty sure it is, but I'm far from an expert on Solaris or Sparc.)

lib/Driver/ToolChains/Gnu.cpp

2467

From my perspective, this is really no worse than what's already here. I tried to avoid changing logic in https://reviews.llvm.org/rL297250, but this function is an example of something that still can use a lot of work.

Since this variable depends on all the parts of the triple, it probably won't break down very cleanly among the various subclasses. That said, if you do want to refactor this, you'll of course want to spend some time to think through exactly how this should work, and spend some time gathering feedback from other Clang devs... so it's probably out of the scope of this patch. I would be happy to help review that change... but, more pragmatically, I'd say land this change first before starting any surgery.

test/Driver/constructors.c

83

Thank you for adding these. :-D Most of the toolchain classes lack explanatory comments about which platform combinations are expected to work for different features, so test cases like this will be invaluable to anyone who wants to refactor parts of the driver.

[fedor.sergeev]

Can anybody commit this for me, please? :-/

[aaron.ballman]

Committed in r308038.

lib/Driver/ToolChains/Gnu.cpp

 }
 
 void Generic_ELF::anchor() {}
 
 void Generic_ELF::addClangTargetOptions(const ArgList &DriverArgs,
                                         ArgStringList &CC1Args,
                                         Action::OffloadKind) const {
   const Generic_GCC::GCCVersion &V = GCCInstallation.getVersion();
   bool UseInitArrayDefault =
       getTriple().getArch() == llvm::Triple::aarch64 ||
       getTriple().getArch() == llvm::Triple::aarch64_be ||
       (getTriple().getOS() == llvm::Triple::Linux &&
        (!V.isOlderThan(4, 7, 0) || getTriple().isAndroid())) ||
       getTriple().getOS() == llvm::Triple::NaCl ||
       (getTriple().getVendor() == llvm::Triple::MipsTechnologies &&
-       !getTriple().hasEnvironment());
+       !getTriple().hasEnvironment()) ||
+      getTriple().getOS() == llvm::Triple::Solaris;
 
   if (DriverArgs.hasFlag(options::OPT_fuse_init_array,
                          options::OPT_fno_use_init_array, UseInitArrayDefault))
     CC1Args.push_back("-fuse-init-array");
 }

lib/Driver/ToolChains/Solaris.h

void ConstructJob(Compilation &C, const JobAction &JA,
                     const llvm::opt::ArgList &TCArgs,
                     const char *LinkingOutput) const override;
 };
 } // end namespace solaris
 } // end namespace tools
 
 namespace toolchains {
 
-class LLVM_LIBRARY_VISIBILITY Solaris : public Generic_GCC {
+class LLVM_LIBRARY_VISIBILITY Solaris : public Generic_ELF {
 public:
   Solaris(const Driver &D, const llvm::Triple &Triple,
           const llvm::opt::ArgList &Args);
 
   bool IsIntegratedAssemblerDefault() const override { return true; }
 
   void AddClangCXXStdlibIncludeArgs(
       const llvm::opt::ArgList &DriverArgs,

lib/Driver/ToolChains/Solaris.cpp

void solaris::Linker::ConstructJob(Compilation &C, const JobAction &JA,
   const char *Exec = Args.MakeArgString(getToolChain().GetLinkerPath());
   C.addCommand(llvm::make_unique<Command>(JA, *this, Exec, CmdArgs, Inputs));
 }
 
 /// Solaris - Solaris tool chain which can call as(1) and ld(1) directly.
 
 Solaris::Solaris(const Driver &D, const llvm::Triple &Triple,
                  const ArgList &Args)
-    : Generic_GCC(D, Triple, Args) {
+    : Generic_ELF(D, Triple, Args) {
 
   GCCInstallation.init(Triple, Args);
 
   path_list &Paths = getFilePaths();
   if (GCCInstallation.isValid())
     addPathIfExists(D, GCCInstallation.getInstallPath(), Paths);
 
   addPathIfExists(D, getDriver().getInstalledDir(), Paths);

test/Driver/constructors.c

 // RUN:     -target arm64-none-linux-gnu \
 // RUN:     --sysroot=%S/Inputs/basic_linux_tree \
 // RUN:     --gcc-toolchain="" \
 // RUN:   | FileCheck --check-prefix=CHECK-INIT-ARRAY %s
 //
 // RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1       \
 // RUN:     -target arm64-none-none-eabi \
 // RUN:   | FileCheck --check-prefix=CHECK-INIT-ARRAY %s
+//
+// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1        \
+// RUN:     -target sparc-sun-solaris2.11 \
+// RUN:   | FileCheck --check-prefix=CHECK-INIT-ARRAY %s
+//
+// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1        \
+// RUN:     -target i386-pc-solaris2.11 \
+// RUN:   | FileCheck --check-prefix=CHECK-INIT-ARRAY %s