This is an archive of the discontinued LLVM Phabricator instance.

Differential D35313

[libFuzzer] Add a dependency on symbolizer from libFuzzer tests
ClosedPublic

Authored by george.karpenkov on Jul 12 2017, 10:51 AM.

Details

Reviewers
kcc
Commits
rG52b2dbb67371: [libFuzzer] Add a dependency on symbolizer from libFuzzer tests
rL307826: [libFuzzer] Add a dependency on symbolizer from libFuzzer tests
Summary

Some libFuzzer tests on Linux would fail with bizarre error messages unless llvm-symbolizer binary is present.
I strongly suspect that CI passes because the machine already has llvm-symbolizer installed in $PATH.

Diff Detail

Event Timeline

george.karpenkov created this revision.Jul 12 2017, 10:51 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 12 2017, 10:51 AM
kcc accepted this revision.Jul 12 2017, 10:51 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 12 2017, 10:51 AM
Closed by commit rL307826: [libFuzzer] Add a dependency on symbolizer from libFuzzer tests (authored by george.karpenkov). · Explain WhyJul 12 2017, 11:18 AM
This revision was automatically updated to reflect the committed changes.
MatzeB added a subscriber: MatzeB.Jul 17 2017, 11:04 AM

I think this broke the greendragon libfuzzer build: http://lab.llvm.org:8080/green/job/libFuzzer/5100/ this one seems like the most likely cause.
Any idea how to get this back to green?

Revision Contents

PathSize
lib/
Fuzzer/
test/
2 lines

Diff 106254

lib/Fuzzer/test/CMakeLists.txt

Show First 20 Lines • Show All 265 Lines • ▼ Show 20 Lines
add_lit_testsuite(check-fuzzer "Running Fuzzer tests" add_lit_testsuite(check-fuzzer "Running Fuzzer tests"
${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_BINARY_DIR}
DEPENDS TestBinaries DEPENDS TestBinaries
) )
# Don't add dependencies on Windows. The linker step would fail on Windows, # Don't add dependencies on Windows. The linker step would fail on Windows,
# since cmake will use link.exe for linking and won't include compiler-rt libs. # since cmake will use link.exe for linking and won't include compiler-rt libs.
if(NOT MSVC) if(NOT MSVC)
add_dependencies(check-fuzzer FileCheck sancov not) add_dependencies(check-fuzzer FileCheck sancov not llvm-symbolizer)
endif() endif()