Allowing cycles in Phi traversal increases the scope of optimize memory instruction
in case we are in loop.
The added test shows an example of enabling optimization inside a loop.
Differential D35294
[CGP] Allow cycles during Phi traversal in OptimizaMemoryInst skatkov on Jul 12 2017, 2:11 AM. Authored by
Details Allowing cycles in Phi traversal increases the scope of optimize memory instruction The added test shows an example of enabling optimization inside a loop.
Diff Detail Event Timeline
Comment Actions Hmmm, it is strange but it appeared not to be sent :( Re-sending.
|
When you're looking through a PHI node, equality can be deceptive; induction variables are the "same", but can have a different value. (We got into trouble with BasicAA doing that recently.) I'd like to see a comment explaining why this particular version of the algorithm is correct.