[clang-import-test] Improve coverage by adding a test and eliminating dead code

[spyffe]

Summary

clang-import-test had some dead code. I did the following to eliminate it:

• eliminated error handling for the indirect CompilerInstance, which should never generate an error as it is created;
• added a new test for direct importation; and
• removed an unused implementation of the CompleteType() API.

This brings clang-import-test.cpp and ExternalASTMerge.cpp back to 100% coverage on all metrics measured by DLLVM_BUILD_INSTRUMENTED_COVERAGE.

[spyffe]

tools/clang-import-test/clang-import-test.cpp

308 ↗

(On Diff #105909)

The original API (BuildIndirect) doesn't even return an Expectedso this is completely dead code. I'm going to eliminate the Expected and the assert.

[spyffe]

Eliminated a useless Expected.

[lhames]

Looks good to me. :)

cfe/trunk/include/clang/AST/ExternalASTMerger.h

public:
 
   bool FindExternalVisibleDeclsByName(const DeclContext *DC,
                                       DeclarationName Name) override;
 
   void
   FindExternalLexicalDecls(const DeclContext *DC,
                            llvm::function_ref<bool(Decl::Kind)> IsKindWeWant,
                            SmallVectorImpl<Decl *> &Result) override;
-
-   using ExternalASTSource::CompleteType;
-
-   void CompleteType(TagDecl *Tag) override;
 };
 
 } // end namespace clang
 
 #endif

cfe/trunk/lib/AST/ExternalASTMerger.cpp

ForEachMatchingDC(
                 IP.Forward->Import(const_cast<Decl *>(SourceDecl));
             assert(ImportedDecl->getDeclContext() == DC);
             (void)ImportedDecl;
           }
         }
       });
 }
 
-void ExternalASTMerger::CompleteType(TagDecl *Tag) {
-  SmallVector<Decl *, 0> Result;
-  FindExternalLexicalDecls(Tag, [](Decl::Kind) { return true; }, Result);
-  Tag->setHasExternalLexicalStorage(false);
-}

cfe/trunk/test/Import/direct/Inputs/S.c

+struct S {
+  int a;
+};

cfe/trunk/test/Import/direct/test.c

+// RUN: clang-import-test -direct -import %S/Inputs/S.c -expression %s
+void expr() {
+  struct S MyS;
+  MyS.a = 3;
+}