HomePhabricator

clang-import-test had some dead code. I did the following to eliminate it:

Description

clang-import-test had some dead code. I did the following to eliminate it:

  • eliminated error handling for the indirect CompilerInstance, which should never generate an error as it is created;
  • added a new test for direct importation; and
  • removed an unused implementation of the CompleteType() API.

This brings clang-import-test.cpp and ExternalASTMerge.cpp back to 100%
coverage on all metrics measured by DLLVM_BUILD_INSTRUMENTED_COVERAGE.

Differential Revision: https://reviews.llvm.org/D35220

Details

Committed
spyffeJul 10 2017, 4:47 PM
Differential Revision
D35220: [clang-import-test] Improve coverage by adding a test and eliminating dead code
Parents
rL307599: Add CFP timeline.
Branches
Unknown
Tags
Unknown