Add an X86 AVX2 clang builder and slave

[eladcohen]

Summary

Add initial builder and slave configurations for an X86-64 AVX2 Linux buildbot

[zvi]

buildbot/osuosl/master/config/builders.py

634

does the 'clang' component in the machine name mean:

• We are using Clang to build LLVM and Clanf

or:

• We are building LLVM + Clang using the Ubuntu default system compiler?

638

Given that we are allowing lots of jobs to run in parallel, should we be using Ninja instead of Make? It's known to scale better.

1121

Looks like this line + 2 below are only white-space changes.

[eladcohen]

buildbot/osuosl/master/config/builders.py

634

We are building LLVM + Clang using the Ubuntu default system compiler.

Following the convention of all the other buildbots, the 'clang' component stands for building LLVM+Clang (Using the ClangCMakeBuildFactory) as opposed to the 'llvm' bots which build llvm without clang.

638

Judging by the other buildbots that use ClangCmakeBuildFactory - It defaults to Ninja

1121

Yes, I'm not sure why my editor added these. I'll remove them.

[gkistanova]

LGTM, assuming you will remove the unrelated cosmetic changes, and figure out what place you want to specify the number of jobs. Up to me, a slave property seems a better and more natural place.

buildbot/osuosl/master/config/builders.py

638

No need to specify a number of jobs here if you did it as the slave property.

[eladcohen]

• Removed the duplicate number of jobs specification.
• Removed the unrelated whitespace changes.

[eladcohen]

Thanks for the review.
Committed in r307753.

[eladcohen]

Committed in r307753.

buildbot/osuosl/master/config/builders.py

#         'factory' : ClangBuilder.getClangBuildFactory(stage1_config='Release+Asserts', run_modern_gdb=True, clean=False)},
                "-DLLVM_OPTIMIZED_TABLEGEN=OFF",
                "-DBUILD_SHARED_LIBS=ON",
                "-DLLVM_BUILD_TESTS=ON",
                "-DLLVM_BUILD_EXAMPLES=OFF",
                "-DCLANG_BUILD_EXAMPLES=OFF",
                "-DLLVM_TARGETS_TO_BUILD=X86",
             ])},
 
+        ## X86_64 AVX2 Clang+LLVM check-all + test-suite
+        {'name': "clang-cmake-x86_64-avx2-linux",
+         'slavenames':["avx2-intel64"],
+         'builddir':"clang-cmake-x86_64-avx2-linux",
+         'factory' : ClangBuilder.getClangCMakeBuildFactory(
+             jobs=80,
+             clean=False,
+             checkout_clang_tools_extra=False,
+             checkout_compiler_rt=False,
+             checkout_lld=False,
+             test=True,
+             useTwoStage=False,
+             runTestSuite=True,
+             nt_flags=['--cflag', '-march=broadwell', '--threads=80', '--build-threads=80'],
+             env={'PATH':'/usr/bin/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'},
+             extra_cmake_args=["-DLLVM_ENABLE_ASSERTIONS=ON",
+                               "-DCMAKE_C_FLAGS='-march=broadwell'",
+                               "-DCMAKE_CXX_FLAGS='-march=broadwell'",
+                               "-DLLVM_TARGETS_TO_BUILD='X86'"])},
+
 #        {'name' : "clang-3stage-ubuntu",
 #         'slavenames' : ["ps4-buildslave1a"],
 #         'builddir' : "clang-3stage-ubuntu",
 #         'factory': ClangLTOBuilder3Stage.get3StageClangLTOBuildFactory(
 #               clean=True,
 #               env=None,
 #               build_gold=True,
 #               cmake_cache_file="../llvm.src/tools/clang/cmake/caches/3-stage.cmake",
return [
         {'name': "libomp-ompt-clang-x86_64-linux-debian",
          'slavenames':["gribozavr4"],
          'builddir':"libomp-ompt-clang-x86_64-linux-debian",
          'factory' : Libiomp5Builder.getLibompCMakeBuildFactory(
                          c_compiler="clang",
                          cxx_compiler="clang++",
                          ompt=True,
                          env={'PATH':'/home/llvmbb/bin/clang-latest/bin:/home/llvmbb/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin'})},
-                         
         {'name': "libomp-clang-ppc64le-linux-debian",
          'slavenames':["ppc64le-nvidia-K40"],
          'builddir':"libomp-clang-ppc64le-linux-debian",
          'factory' : Libiomp5Builder.getLibompCMakeBuildFactory(
                          c_compiler="/home/bbot/opt/clang/bin/clang",
                          cxx_compiler="/home/bbot/opt/clang/bin/clang++",
                          env={'PATH':'/home/bbot/opt/cmake/bin:/home/bbot/opt/ninja/bin:/usr/local/bin:/usr/bin:/bin'})},
 
         ]
 
 def _get_libcxx_builders():
     ericwf_slaves = ['ericwf-buildslave2', 'ericwf-buildslave',
                      'ericwf-buildslave-fast']
     return [
-        # gribozavr's builders on gribozavr4 
+        # gribozavr's builders on gribozavr4
         {'name': 'libcxx-libcxxabi-x86_64-linux-debian',
          'slavenames': ['gribozavr4'],
          'builddir': 'libcxx-libcxxabi-x86_64-linux-debian',
          'factory': LibcxxAndAbiBuilder.getLibcxxAndAbiBuilder(
              env={'CC': 'clang', 'CXX': 'clang++'},
              lit_extra_args=['--shuffle'],
              check_libcxx_abilist=True),
          'category': 'libcxx'},

buildbot/osuosl/master/config/slaves.py

return [
         create_slave("ppc64be-clang-multistage-test", properties={'jobs': 16}, max_builds=1),
         create_slave("ppc64be-sanitizer", properties={'jobs': 16}, max_builds=1),
 
         # POWER 8 PowerPC little endian (powerpc64le)
         create_slave("ppc64le-clang-test", properties={'jobs': 4}, max_builds=1),
         create_slave("ppc64le-clang-lnt-test", properties={'jobs': 8}, max_builds=1),
         create_slave("ppc64le-clang-multistage-test", properties={'jobs': 8}, max_builds=1),
         create_slave("ppc64le-sanitizer", properties={'jobs': 4}, max_builds=1),
-        
         # POWER 8 PowerPC little endian (powerpc64le) with NVIDIA GPUs
         create_slave("ppc64le-nvidia-K40", properties={'jobs': 4}, max_builds=1),
 
         # Ubuntu x86-64, Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz
         create_slave("hexagon-build-02", properties={'jobs': 12, 'loadaverage': 32},
             max_builds=1),
 
         # Ubuntu x86-64, Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz
return [
         create_slave("am1i-slv1", properties={'jobs': 8}),
 
         # Ubuntu 16.04.2 LTS, AMD Athlon(tm) 5150 APU with Radeon(tm) R3, 8GiB RAM
         create_slave("am1i-slv2", properties={'jobs': 8}),
 
         # Ubuntu 14.04 x86_64, AMD Athlon(tm) 5150 APU with Radeon(tm) R3, 8GiB RAM
         create_slave("am1i-slv3", properties={'jobs': 8}),
 
+        # X86_64 AVX2, Ubuntu 16.04.2, Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
+        create_slave("avx2-intel64", properties={'jobs': 80}, max_builds=1),
+
         # Defunct.
         # Debian 86_64, 2 x 6-core Opteron 2.6 GHz
         #create_slave("osu8", properties={'jobs' : 6}, max_builds=2),
 
         # OpenBSD
         #create_slave("openbsd-buildslave", properties={'jobs': 2}, max_builds=1),
 
         # Ubuntu 14.04 x86_64, Intel(R) Xeon(R) CPU @ 2.30GHz