Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D35178

[GlobalISel][X86] Support G_LOAD/G_STORE i1.
ClosedPublic
Actions

Authored by igorb on Jul 9 2017, 4:20 AM.

Details

Reviewers
zvi
guyblank
Commits
rGd8b51e134ede: [GlobalISel][X86] Support G_LOAD/G_STORE i1.
rL307527: [GlobalISel][X86] Support G_LOAD/G_STORE i1.
Summary

Support G_LOAD/G_STORE i1.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb created this revision.Jul 9 2017, 4:20 AM
Herald added subscribers: kristof.beyls, rovka. · View Herald TranscriptJul 9 2017, 4:20 AM
Harbormaster completed remote builds in B8079: Diff 105757.Jul 9 2017, 6:15 AM
guyblank added inline comments.Jul 10 2017, 12:32 AM
test/CodeGen/X86/GlobalISel/memop-scalar-x32.ll
7 ↗(On Diff #105757)

should there be an AND here for the truncation to i1?

igorb added inline comments.Jul 10 2017, 12:39 AM
test/CodeGen/X86/GlobalISel/memop-scalar-x32.ll
7 ↗(On Diff #105757)

No, truncate only drop the bits.
for reference DagISEL generate the same code

guyblank accepted this revision.Jul 10 2017, 1:33 AM
This revision is now accepted and ready to land.Jul 10 2017, 1:33 AM
Closed by commit rL307527: [GlobalISel][X86] Support G_LOAD/G_STORE i1. (authored by ibreger). · Explain WhyJul 10 2017, 2:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Target/
X86/
2 lines
test/
CodeGen/
X86/
GlobalISel/
10 lines
22 lines
20 lines

Diff 105823

View Options

llvm/trunk/lib/Target/X86/X86LegalizerInfo.cpp

Loading...
View Options

llvm/trunk/test/CodeGen/X86/GlobalISel/legalize-memop-scalar.mir

Loading...
View Options

llvm/trunk/test/CodeGen/X86/GlobalISel/memop-scalar-x32.ll

Loading...
View Options

llvm/trunk/test/CodeGen/X86/GlobalISel/memop-scalar.ll

Loading...