Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
compiler-rt/trunk/lib/lsan/lsan_common.cc | ||
---|---|---|
81 | Minor, but I'd love to know a bit more of the context (is it a bug in some versions or design decision, is it going to be fixed or we're stuck with it forever etc.) and add #if SANITIZER_MAC around it? |
compiler-rt/trunk/lib/lsan/lsan_common.cc | ||
---|---|---|
81 | Oh, I'm sorry for not explaning more, I only to talked to @fjricci (who's the primary person for LSan on Darwin) in a private email about this. I'm seeing multiple test failures in ASan tests, all of which are due to this LSan false positive. It only affects 10.12 systems, because it's specific to the new "unified logging" mechanism on 10.12, but the leak is only reported in specific versions of the OS. This is not a "real" solution, and I believe @fjricci is going to investigate if there's a better way of handling this. But since I'm having multiple test failures (not on public bots, though, they are all on 10.11), I wanted to land a "fix" even if means using the suppression list. Here's some details about the problem:
I will add a #if SANITIZER_MAC. |
compiler-rt/trunk/lib/lsan/lsan_common.cc | ||
---|---|---|
81 | Added the #if in r307567. |
Yes, I'm going to look into handling this via memory region scanning, but it's possible (even likely) that the performance hit will be prohibitive.
Minor, but I'd love to know a bit more of the context (is it a bug in some versions or design decision, is it going to be fixed or we're stuck with it forever etc.) and add #if SANITIZER_MAC around it?