Page MenuHomePhabricator

[Driver] Honor -isysroot for Linux targets
Needs ReviewPublic

Authored by yan12125 on Jul 7 2017, 11:31 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

yan12125 created this revision.Jul 7 2017, 11:31 AM
rsmith added a subscriber: rsmith.Jul 7 2017, 11:48 AM

This needs tests; perhaps extend test/Driver/linux-header-search.cpp for this.

lib/Driver/ToolChains/Linux.cpp
421

Can you instead return computeSysRoot() here and remove the fallback from BuildCompilation? That way, we won't perform the checks in defaultSysRoot twice if neither flag is specified.

rsmith set the repository for this revision to rL LLVM.
rsmith edited subscribers, added: cfe-commits; removed: rsmith.
yan12125 updated this revision to Diff 107777.Jul 22 2017, 12:37 AM

Add a test and fix repeated call to defaultSysRoot()

Bump. Anything missing on this patch?