This is an archive of the discontinued LLVM Phabricator instance.

Differential D35125

Unbreak shared library linkage on DragonFlyBSD.
ClosedPublic

Authored by rimvydas on Jul 7 2017, 9:19 AM.

Details

Reviewers
llvm-commits
krytarowski
mgorny
Commits
rG0c5b6ede2ff1: Unbreak shared library linkage on DragonFlyBSD.
rL355315: Unbreak shared library linkage on DragonFlyBSD.

Diff Detail

Repository
rL LLVM

Event Timeline

rimvydas created this revision.Jul 7 2017, 9:19 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 7 2017, 9:19 AM
krytarowski accepted this revision.Mar 4 2019, 6:21 AM
This revision is now accepted and ready to land.Mar 4 2019, 6:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2019, 6:21 AM
mgorny accepted this revision.Mar 4 2019, 6:28 AM
Closed by commit rL355315: Unbreak shared library linkage on DragonFlyBSD. (authored by kamil). · Explain WhyMar 4 2019, 6:36 AM
This revision was automatically updated to reflect the committed changes.
devnexen added a subscriber: devnexen.Mar 4 2019, 7:54 AM

Was there a bug ? :-) I remember I added the check already a while ago.

Revision Contents

PathSize
llvm/
trunk/
cmake/
modules/
1 line

Diff 189138

llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Linesif(APPLE)
endif() endif()
# Darwin-specific linker flags for loadable modules. # Darwin-specific linker flags for loadable modules.
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress") set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress")
endif() endif()
# Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO # Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO
# build might work on ELF but fail on MachO/COFF. # build might work on ELF but fail on MachO/COFF.
if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR CYGWIN OR if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR CYGWIN OR
${CMAKE_SYSTEM_NAME} MATCHES "DragonFly" OR
${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD" OR ${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD" OR
${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD" OR ${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD" OR
${CMAKE_SYSTEM_NAME} MATCHES "DragonFly") AND ${CMAKE_SYSTEM_NAME} MATCHES "DragonFly") AND
NOT LLVM_USE_SANITIZER) NOT LLVM_USE_SANITIZER)
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs") set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
endif() endif()
# Pass -Wl,-z,nodelete. This makes sure our shared libraries are not unloaded # Pass -Wl,-z,nodelete. This makes sure our shared libraries are not unloaded
▲ Show 20 Lines • Show All 800 Lines • Show Last 20 Lines