[Solaris] get rid of _RESTRICT_KYWD warning during the build

[fedor.sergeev]

Summary

(re)definition of _RESTRICT_KYWD rightfully causes a warning message during the Solaris build.
This hack is not needed if build compiler is properly configured (.e.g /usr/bin/gcc) so just remove it.

[fedor.sergeev]

The hack was introduced as part of rL192185 Solaris-11 build change.
After removing this hack I have no problems building LLVM on Solaris 11 (intel/SPARC).

Vladimir V (the guy who did the original fix) does not really remember what was his exact build setup that exposed the problem with _RESTRICT_KYWD.
I just suppose that his gcc had no include-fixed feature_tests.h (which has a fix for _RESTRICT_KYWD) and that resulted in _RESTRICT_KYWD
being defined as "restrict" (leading to g++ errors on majority of its uses in Solaris headers).

I wonder if anybody can check what happens on non-Oracle Solarii...

[krytarowski]

Removal of this hack is needed on SmartOS.

pkgsrc: lang/libLLVM/patches/patch-lib_Support_Unix_Program.inc

It reappeared in libLLVM setup.

[joerg]

LGTM, as Kamil said, we have the same change in pkgsrc for Illumos.

[fedor.sergeev]

Joerg, Kamil, mind to integrate this?
I still have no commit rights...

regards,

Fedor.

[krytarowski]

Committed as SVN r.307469

lib/Support/Unix/Program.inc

 #endif
 #if HAVE_FCNTL_H
 #include <fcntl.h>
 #endif
 #if HAVE_UNISTD_H
 #include <unistd.h>
 #endif
 #ifdef HAVE_POSIX_SPAWN
-#ifdef __sun__
-#define  _RESTRICT_KYWD
-#endif
 #include <spawn.h>
 
 #if defined(__APPLE__)
 #include <TargetConditionals.h>
 #endif
 
 #if defined(__APPLE__) && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
 #define USE_NSGETENVIRON 1