This is an archive of the discontinued LLVM Phabricator instance.

[DWARF] - Provide default implementations for methods of LoadedObjectInfo
ClosedPublic

Authored by grimar on Jul 5 2017, 4:51 AM.

Details

Summary

It is a bit unconvinent that client should implement stubs for these two methods
on its side even if not use them at all.

For example in D35005 I do not need them both, also there is one more
place in LLD where LoadedObjectInfo is used and have to implement stub clone()
method.

I suggest to provide default implementations.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Jul 5 2017, 4:51 AM
dblaikie accepted this revision.Jul 5 2017, 9:03 AM

getSectionLoadAddress seems fine - but I've fixed/improved the clone situation by generalizing a CRTP base helper in r307166, so you can probably use that in your other change

This revision is now accepted and ready to land.Jul 5 2017, 9:03 AM
grimar added a comment.Jul 6 2017, 1:43 AM

but I've fixed/improved the clone situation by generalizing a CRTP base helper in r307166, so you can probably use that in your other change

Cool, thanks !

This revision was automatically updated to reflect the committed changes.