This is an archive of the discontinued LLVM Phabricator instance.

clang: add support for hard float musl linux targets.
Needs ReviewPublic

Authored by martell on Jul 3 2017, 9:19 AM.

Details

Reviewers
pcc
krytarowski
Summary

This might seems a little confusing on a first look but llvm::Triple::GNUEABIHF generally refers to a glibc hf triple.
We just apply the same logic to llvm::Triple::MuslEABIHF because if just refers to the c library.

There doesn't seem to be an existing testcase for the llvm::Triple::GNUEABIHF logic.
The only question I have is should we apply the same logic for FreeBSD targets with musl?

Diff Detail

Repository
rL LLVM

Event Timeline

martell created this revision.Jul 3 2017, 9:19 AM
krytarowski edited edge metadata.Jul 5 2017, 6:51 AM

Next time please send patches with git diff -U999, it will be easier to review.

krytarowski resigned from this revision.Jul 6 2017, 8:03 AM

I'm not sure about Triples here.

@krytarowski for context this is the triple alpine expects
https://git.alpinelinux.org/cgit/aports/tree/main/clang/clang-0004-Add-musl-targets.patch?h=3.6-stable
Would be nice to get this in shape so we can use alpine in conjunction with docker files added by rL306810