This is an archive of the discontinued LLVM Phabricator instance.

[pdb] Add a test for every known CodeView type
ClosedPublic

Authored by zturner on Jun 30 2017, 3:40 PM.

Details

Summary

This test should eventually supersede some of our other tests, as this is self-contained and covers a lot of the things that the other tests already do, but more concisely.

Diff Detail

Event Timeline

zturner created this revision.Jun 30 2017, 3:40 PM
rnk accepted this revision.Jun 30 2017, 3:51 PM

lgtm

This revision is now accepted and ready to land.Jun 30 2017, 3:51 PM
This revision was automatically updated to reflect the committed changes.
amccarth added inline comments.
llvm/test/DebugInfo/PDB/Inputs/every-type.cpp
12

Class enums still use LF_ENUM, right? Do we care about the underlying integral type?

zturner added inline comments.Jul 5 2017, 5:02 PM
llvm/test/DebugInfo/PDB/Inputs/every-type.cpp
12

Yes it still uses LF_ENUM. And I don't think we care about the underlying type, all we care about is making sure that the reading and writing code for every leaf and member type is exercised by the test. The underlying type is just going to be a simple type, so we don't really care what it is as we aren't serializing / deserializing it.