This is an archive of the discontinued LLVM Phabricator instance.

Differential D34893

[ELF] - Remove use of precomipled binary for invalid-relocation-x64.test
ClosedPublic

Authored by grimar on Jun 30 2017, 9:22 AM.

Details

Reviewers
ruiu
• rafael
Commits
rGbd4943e2ca72: [ELF] - Remove use of precomipled binary for invalid-relocation-x64.test
rLLD307032: [ELF] - Remove use of precomipled binary for invalid-relocation-x64.test
rL307032: [ELF] - Remove use of precomipled binary for invalid-relocation-x64.test
Summary

Since yaml2obj is now able to parse integer values as relocation types,
there is no need to keep hex edited elf object for this test,
we can produce it on fly, just like this patch do.

Diff Detail

Event Timeline

grimar created this revision.Jun 30 2017, 9:22 AM
Herald added a subscriber: emaste. · View Herald TranscriptJun 30 2017, 9:22 AM
ruiu accepted this revision.Jun 30 2017, 9:25 AM

LGTM

test/ELF/invalid/invalid-relocation-x64.test
1

Please add "REQUIRES: x86".

This revision is now accepted and ready to land.Jun 30 2017, 9:25 AM
Closed by commit rL307032: [ELF] - Remove use of precomipled binary for invalid-relocation-x64.test (authored by grimar). · Explain WhyJul 3 2017, 8:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
ELF/
invalid/
Inputs/
17 lines

Diff 104876

test/ELF/invalid/Inputs/invalid-relocation-x64.elf

  • This is a binary file.
PropertyOld ValueNew Value
svn:mime-typeapplication/octet-stream
\ No newline at end of property		null

test/ELF/invalid/invalid-relocation-x64.test

## invalid-relocation-x64.elf contains relocations with invalid relocation number. # RUN: yaml2obj %s -o %t.o
ruiuUnsubmitted
Not Done
ReplyInline Actions

Please add "REQUIRES: x86".

ruiu: Please add "REQUIRES: x86".
## Next yaml code was used to create initial binary. After that it # RUN: not ld.lld %t.o -o /dev/null 2>&1 | FileCheck %s
## was modified with hex-editor to replace known relocations with fake ones, # CHECK: {{.*}}.o: unknown relocation type: Unknown (152)
## that have 0x98 and 0x98 numbers. # CHECK: {{.*}}.o: unknown relocation type: Unknown (153)
!ELF !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
OSABI: ELFOSABI_FREEBSD OSABI: ELFOSABI_FREEBSD
Type: ET_REL Type: ET_REL
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .text - Name: .text
Type: SHT_PROGBITS Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
- Name: .rela.text - Name: .rela.text
Type: SHT_RELA Type: SHT_RELA
Link: .symtab Link: .symtab
Info: .text Info: .text
Relocations: Relocations:
- Offset: 0x0000000000000000 - Offset: 0x0000000000000000
Symbol: '' Symbol: ''
Type: R_X86_64_NONE Type: 0x98
- Offset: 0x0000000000000000 - Offset: 0x0000000000000000
Symbol: '' Symbol: ''
Type: R_X86_64_NONE Type: 0x99
# RUN: not ld.lld %p/Inputs/invalid-relocation-x64.elf -o %t2 2>&1 | FileCheck %s
# CHECK: {{.*}}invalid-relocation-x64.elf: unknown relocation type: Unknown (152)
# CHECK: {{.*}}invalid-relocation-x64.elf: unknown relocation type: Unknown (153)