Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D34877

[mips] Implement the 'dins' aliases.
ClosedPublic
Actions

Authored by sdardis on Jun 30 2017, 5:27 AM.

Details

Reviewers
slthakur
Commits
rG6f83ae38a33b: [mips] Implement the 'dins' aliases.
rL313267: [mips] Implement the 'dins' aliases.
Summary

Traditionally GAS has provided automatic selection between dins, dinsm and
dinsu. Binutils also disassembles all instructions in that family as 'dins'
rather than the actual instruction.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis created this revision.Jun 30 2017, 5:27 AM
Herald added a subscriber: arichardson. · View Herald TranscriptJun 30 2017, 5:27 AM
sdardis added a child revision: D34887: [mips] Implement the 'dext' aliases and it's disassembly alias..Jun 30 2017, 7:49 AM
sdardis added a parent revision: D34809: [mips] Pick the right variant of DINS upfront and enable target instruction verification.
sdardis added a comment.Jul 14 2017, 11:51 AM

ping.

slthakur accepted this revision.Jul 17 2017, 5:45 AM

LGTM

This revision is now accepted and ready to land.Jul 17 2017, 5:45 AM
Closed by commit rL313267: [mips] Implement the 'dins' aliases. (authored by sdardis). · Explain WhySep 14 2017, 8:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Target/
Mips/
AsmParser/
36 lines
Disassembler/
69 lines
26 lines
31 lines
2 lines
test/
MC/
Disassembler/
Mips/
micromips64r6/
4 lines
Mips/
micromips64r6/
1 line
2 lines
2 lines
30 lines

Diff 115224

View Options

llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp

Loading...
View Options

llvm/trunk/lib/Target/Mips/Disassembler/MipsDisassembler.cpp

Loading...
View Options

llvm/trunk/lib/Target/Mips/MicroMips64r6InstrInfo.td

Loading...
View Options

llvm/trunk/lib/Target/Mips/Mips64InstrInfo.td

Loading...
View Options

llvm/trunk/lib/Target/Mips/MipsInstrInfo.td

Loading...
View Options

llvm/trunk/test/MC/Disassembler/Mips/micromips64r6/valid.txt

Loading...
View Options

llvm/trunk/test/MC/Mips/micromips64r6/invalid-wrong-error.s

Loading...
View Options

llvm/trunk/test/MC/Mips/micromips64r6/invalid.s

Loading...
View Options

llvm/trunk/test/MC/Mips/micromips64r6/valid.s

Loading...
View Options

llvm/trunk/test/MC/Mips/mips64extins.s

Loading...