Page MenuHomePhabricator

[OpenCL] Add function name to extension diagnostic
AbandonedPublic

Authored by joey on Jun 30 2017, 1:49 AM.

Details

Reviewers
bader
Summary

Slightly improve the diagnostic by including the function name.

This has been separated out from https://reviews.llvm.org/D33945.

Diff Detail

Event Timeline

joey created this revision.Jun 30 2017, 1:49 AM
bader accepted this revision.Jun 30 2017, 2:48 AM

LGTM.
Just one minor comment.
Thanks.

clang/Sema/Sema.h
8435

I think it's better to use NamedDecl to allow this function be used for declarations other than FunctionDecl.

This revision is now accepted and ready to land.Jun 30 2017, 2:48 AM
joey added a comment.Jun 30 2017, 4:49 AM

Thanks!

Making that change, going to re-run the tests and then I'll commit.

joey abandoned this revision.Feb 14 2019, 2:16 AM