This is an archive of the discontinued LLVM Phabricator instance.

Differential D34761

[Bash-autocompletion] Invoke clang where user called
ClosedPublic

Authored by yamaguchi on Jun 28 2017, 9:23 AM.

Details

Reviewers
ruiu
v.g.vassilev
teemperor
Commits
rG28782bea886c: [Bash-autocompletion] Invoke clang where user called
rC306559: [Bash-autocompletion] Invoke clang where user called
rL306559: [Bash-autocompletion] Invoke clang where user called
Summary

When user build clang and used completion Eg. build/bin/clang -fno[tab] , we want to invoke build/bin/clang --autocomplete=-fno , rather than clang --autocomplete=-fno .

Diff Detail

Repository
rL LLVM

Event Timeline

yamaguchi created this revision.Jun 28 2017, 9:23 AM
yamaguchi edited the summary of this revision. (Show Details)Jun 28 2017, 9:24 AM
yamaguchi edited the summary of this revision. (Show Details)
yamaguchi edited the summary of this revision. (Show Details)
v.g.vassilev accepted this revision.Jun 28 2017, 9:26 AM

LGTM.

This revision is now accepted and ready to land.Jun 28 2017, 9:26 AM
ruiu accepted this revision.Jun 28 2017, 9:26 AM

LGTM

Closed by commit rL306559: [Bash-autocompletion] Invoke clang where user called (authored by yamaguchi). · Explain WhyJun 28 2017, 9:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
utils/
2 lines

Diff 104439

cfe/trunk/utils/bash-autocomplete.sh

Show All 18 Lines_clang()
elif [[ "$w1" == -* ]]; then elif [[ "$w1" == -* ]]; then
# -foo <tab> or -foo bar<tab> # -foo <tab> or -foo bar<tab>
arg="$w1,$cur" arg="$w1,$cur"
elif [[ "$w2" == -* && "$w1" == '=' ]]; then elif [[ "$w2" == -* && "$w1" == '=' ]]; then
# -foo=bar<tab> # -foo=bar<tab>
arg="$w2=,$cur" arg="$w2=,$cur"
fi fi
flags=$( clang --autocomplete="$arg" 2>/dev/null ) flags=$( "${COMP_WORDS[0]}" --autocomplete="$arg" 2>/dev/null )
# If clang is old that it does not support --autocomplete, # If clang is old that it does not support --autocomplete,
# fall back to the filename completion. # fall back to the filename completion.
if [[ "$?" != 0 ]]; then if [[ "$?" != 0 ]]; then
_filedir _filedir
return return
fi fi
if [[ "$cur" == '=' ]]; then if [[ "$cur" == '=' ]]; then
Show All 11 Lines