This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Fix plotting issue caused by r188111
ClosedPublic

Authored by kongyi on Apr 23 2014, 2:16 AM.

Details

Summary

The bug is introduced in revision 188111, when date is added to graph point metadata. min(enumerate(values)) is used to retrieve both minimum value and its index. However Python prioritize the first element in tuple when sorting, thus the actual value retrieved is the first run value. The fix flips the elements of tuple so that the value is prioritized over run order.

No new regression is introduced because the changed value is local.

Diff Detail

Event Timeline

kongyi updated this revision to Diff 8766.Apr 23 2014, 2:16 AM
kongyi retitled this revision from to [LNT] Fix plotting issue caused by r188111.
kongyi updated this object.
kongyi edited the test plan for this revision. (Show Details)
kongyi added a subscriber: Unknown Object (MLST).
kongyi added a subscriber: gottesmm.
kongyi accepted this revision.Jun 25 2014, 12:52 PM
kongyi added a reviewer: kongyi.
This revision is now accepted and ready to land.Jun 25 2014, 12:52 PM
kongyi closed this revision.Jun 25 2014, 12:52 PM