[opt-viewer] Handle file names that contain '#'

[modocache]

Summary

When using opt-viewer.py with files with '#' in their name, such as
'foo#bar.cpp', opt-viewer.py would generate links such as
'/path/to/foo#bar.cpp.opt.yaml#L42'. In this case, the link is
interpreted by browsers as a link to the file '/path/to/foo', and to the
section within that file with ID 'bar.cpp.opt.yaml#L42'.

To work around this issue, replace '#' with '_' in file names and links
in opt-viewer.py.

[modocache]

@anemet Friendly ping! I know this seems like a silly change, but build tools like https://buckbuild.com produce many file names with # in them, which really messes with the links in opt-viewer :)

[davidxl]

lgtm

[modocache]

Rebasing onto trunk in order to pick up the file mv from utils/ to tools/.

[modocache]

Thanks @davidxl, much appreciated!

tools/opt-viewer/optrecord.py

 def demangle(name):
     with p_lock:
         p.stdin.write((name + '\n').encode('utf-8'))
         p.stdin.flush()
         return p.stdout.readline().rstrip().decode('utf-8')
 
 
 def html_file_name(filename):
-    return filename.replace('/', '_') + ".html"
+    return filename.replace('/', '_').replace('#', '_') + ".html"
 
 
 def make_link(File, Line):
     return "\"{}#L{}\"".format(html_file_name(File), Line)
 
 
 class Remark(yaml.YAMLObject):
     # Work-around for http://pyyaml.org/ticket/154.