[GSoC] Delete space after flags which has '=' prefix

[yamaguchi]

Summary

This is patch for bash completion for clang project.
We don't need space when completing options like "-stdlib=".

[yamaguchi]

Fixed review comment.

[ruiu]

clang/utils/bash-autocomplete.sh

4

Do you need to set arg to ""? I thought that variables defined by local would automatically get an empty value.

33–35

A shorthand notation of this which is used often in shell programming is

[[ ${flag:-1} == '=' ]] && compopt -o nospace

Can you add a comment to describe why you need this? Something like "bash automatically appends a space after '=' by default. Disable it so that it works nicely for options in the form of -foo=bar."

[yamaguchi]

Update diff.

[ruiu]

LGTM

clang/utils/bash-autocomplete.sh

 # Please add "source /path/to/bash-autocomplete.sh" to your .bashrc to use this.
 _clang()
 {
   local cur prev words cword arg
   _init_completion -n : || return
 
   # bash always separates '=' as a token even if there's no space before/after '='.
   # On the other hand, '=' is just a regular character for clang options that
   # contain '='. For example, "-stdlib=" is defined as is, instead of "-stdlib" and "=".
   # So, we need to partially undo bash tokenization here for integrity.
   local w1="${COMP_WORDS[$cword - 1]}"
   local w2="${COMP_WORDS[$cword - 2]}"
   if [[ "$cur" == -* ]]; then
     # -foo<tab>
     arg="$cur"
   elif [[ "$w1" == -*  && "$cur" == '=' ]]; then
     # -foo=<tab>
     arg="$w1=,"
   elif [[ "$w1" == -* ]]; then
     # -foo <tab> or -foo bar<tab>
     arg="$w1,$cur"
   elif [[ "$w2" == -* && "$w1" == '=' ]]; then
     # -foo=bar<tab>
     arg="$w2=,$cur"
-  else
-    _filedir
   fi
 
   local flags=$( clang --autocomplete="$arg" )
-  if [[ "$cur" == "=" ]]; then
+  if [[ "$cur" == '=' ]]; then
     COMPREPLY=( $( compgen -W "$flags" -- "") )
-  elif [[ "$flags" == "" ]]; then
+  elif [[ "$flags" == "" || "$arg" == "" ]]; then
     _filedir
   else
+    # Bash automatically appends a space after '=' by default.
+    # Disable it so that it works nicely for options in the form of -foo=bar.
+    [[ "${flags: -1}" == '=' ]] && compopt -o nospace
     COMPREPLY=( $( compgen -W "$flags" -- "$cur" ) )
   fi
 }
 complete -F _clang clang