[opt-viewer] Remove positional arg checks (NFC)

[modocache]

Summary

opt-stats.py and opt-viewer.py's argument parsers both take a positional
argument 'yaml_files'. Positional arguments in Python's argparse module are
required by default, so the subsequent checks for len(args.yaml_files) == 0
are unnecessary -- if the length was zero, then the call to
parser.parse_args() would have thrown an error already.

Because there is no way for len(args.yaml_files) to be zero at these
points, removing the code is NFC.

[anemet]

LGTM, thanks!

[modocache]

Thank you, @anemet!

utils/opt-viewer/opt-stats.py

if __name__ == '__main__':
     parser.add_argument(
         '--jobs',
         '-j',
         default=cpu_count(),
         type=int,
         help='Max job count (defaults to %(default)s, the current CPU count)')
     args = parser.parse_args()
 
-    if len(args.yaml_files) == 0:
-        parser.print_help()
-        sys.exit(1)
-
     if args.jobs == 1:
         pmap = map
     else:
         pool = Pool(processes=args.jobs)
         pmap = pool.map
 
     all_remarks, file_remarks, _ = optrecord.gather_results(pmap, args.yaml_files)
 

utils/opt-viewer/opt-viewer.py

parser.add_argument(
         help='Max job count (defaults to %(default)s, the current CPU count)')
     parser.add_argument(
         '-source-dir',
         '-s',
         default='',
         help='set source directory')
     args = parser.parse_args()
 
-    if len(args.yaml_files) == 0:
-        parser.print_help()
-        sys.exit(1)
-
     if args.jobs == 1:
         pmap = map
     else:
         pool = Pool(processes=args.jobs)
         pmap = pool.map
 
     all_remarks, file_remarks, should_display_hotness = optrecord.gather_results(pmap, args.yaml_files)
 
     map_remarks(all_remarks)
 
     generate_report(pmap, all_remarks, file_remarks, args.source_dir, args.output_dir, should_display_hotness)