This is an archive of the discontinued LLVM Phabricator instance.

Make getNameStr return original name of the Scop

Authored by singam-sanjay on Jun 23 2017, 11:55 AM.



The current implementation of Scop::getNameStr builds the name from the current boundaries of the Region, which might not be the original boundaries if getNameStr was called during or after applying the transformation to the Region.

Scop::getNameStr is altered to return the original name and Scop::getCurrentNameStr returns the name considering the current boundary of the Region.

Diff Detail


Event Timeline

singam-sanjay created this revision.Jun 23 2017, 11:55 AM

This patch corrects the semantics of the accessor methods of the Scop class.

This patch is required by D33985, to prefix the name of the Scop to the name of the kernel, which currently manages without this with a hack.

I could even push the construction of std::string ScopNameForIR from GPUNodeBuilder in D33985 into Scop as a part of this patch.

Please share your thoughts.

bollu edited edge metadata.EditedJun 25 2017, 3:07 AM

@singam-sanjay I believe I commented on the changes in patch [D33985](

grosser edited edge metadata.Jul 10 2017, 10:28 PM

After we decided to number the scops, this patch is not needed any more, right? Should it be dropped?

singam-sanjay abandoned this revision.Jul 12 2017, 9:34 PM

Yes. I'll drop it.