This is an archive of the discontinued LLVM Phabricator instance.

Fix typo: using && instead of & when evaluating a mask
ClosedPublic

Authored by mehdi_amini on Jun 22 2017, 10:19 PM.

Reviewers

zturner
sas

Commits

Summary

Reported by coverity, I don't know how to provide a test.

This revision is now accepted and ready to land.Jun 22 2017, 10:32 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

trunk/

source/

Plugins/

ObjectFile/

ELF/

2 lines

Show First 20 Lines • Show All 1,687 Lines • ▼ Show 20 Lines	if (shstr_data.SetData(object_data, offset, byte_size) == byte_size) {
break;		break;
case EF_MIPS_ABI_EABI64:		case EF_MIPS_ABI_EABI64:
arch_flags \|= lldb_private::ArchSpec::eMIPSABI_EABI64;		arch_flags \|= lldb_private::ArchSpec::eMIPSABI_EABI64;
break;		break;
default:		default:
// ABI Mask doesn't cover N32 and N64 ABI.		// ABI Mask doesn't cover N32 and N64 ABI.
if (header.e_ident[EI_CLASS] == llvm::ELF::ELFCLASS64)		if (header.e_ident[EI_CLASS] == llvm::ELF::ELFCLASS64)
arch_flags \|= lldb_private::ArchSpec::eMIPSABI_N64;		arch_flags \|= lldb_private::ArchSpec::eMIPSABI_N64;
else if (header.e_flags && llvm::ELF::EF_MIPS_ABI2)		else if (header.e_flags & llvm::ELF::EF_MIPS_ABI2)
arch_flags \|= lldb_private::ArchSpec::eMIPSABI_N32;		arch_flags \|= lldb_private::ArchSpec::eMIPSABI_N32;
break;		break;
}		}
arch_spec.SetFlags(arch_flags);		arch_spec.SetFlags(arch_flags);
}		}

if (arch_spec.GetMachine() == llvm::Triple::arm \|\|		if (arch_spec.GetMachine() == llvm::Triple::arm \|\|
arch_spec.GetMachine() == llvm::Triple::thumb) {		arch_spec.GetMachine() == llvm::Triple::thumb) {
▲ Show 20 Lines • Show All 1,702 Lines • Show Last 20 Lines