This is an archive of the discontinued LLVM Phabricator instance.

Differential D34486

MC: Fix dumping of MCFragment values
ClosedPublic

Authored by sbc100 on Jun 21 2017, 4:35 PM.

Details

Reviewers
dschuff
Commits
rG58ad080ef00a: MC: Fix dumping of MCFragment values
rL306039: MC: Fix dumping of MCFragment values
Summary

Without this cast the "char" overload of operator<< is
chosen and the values are output as an ascii char rather
than an integer.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jun 21 2017, 4:35 PM
Harbormaster completed remote builds in B7473: Diff 103488.Jun 21 2017, 4:35 PM
sbc100 updated this revision to Diff 103489.Jun 21 2017, 4:37 PM
sbc100 retitled this revision from Fix dumping of fill fragment values Without this cast the "char" overload of operator<< is chosen and the fill value is output as an ascii rather than an integer. to Fix dumping of fill fragment values.
sbc100 edited the summary of this revision. (Show Details)

use cast

sbc100 edited the summary of this revision. (Show Details)Jun 21 2017, 4:38 PM
sbc100 added a reviewer: dschuff.
sbc100 retitled this revision from Fix dumping of fill fragment values to MC: Fix dumping of MCFragment values.Jun 21 2017, 4:40 PM
sbc100 added a subscriber: llvm-commits.
dschuff accepted this revision.Jun 21 2017, 5:09 PM
This revision is now accepted and ready to land.Jun 21 2017, 5:09 PM
Closed by commit rL306039: MC: Fix dumping of MCFragment values (authored by sbc). · Explain WhyJun 22 2017, 10:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
MC/
6 lines

Diff 103605

llvm/trunk/lib/MC/MCFragment.cpp

Show First 20 Lines • Show All 376 Lines • ▼ Show 20 Lines for (unsigned i = 0, e = Contents.size(); i != e; ++i) {
if (i) OS << ","; if (i) OS << ",";
OS << hexdigit((Contents[i] >> 4) & 0xF) << hexdigit(Contents[i] & 0xF); OS << hexdigit((Contents[i] >> 4) & 0xF) << hexdigit(Contents[i] & 0xF);
} }
OS << "] (" << Contents.size() << " bytes)"; OS << "] (" << Contents.size() << " bytes)";
break; break;
} }
case MCFragment::FT_Fill: { case MCFragment::FT_Fill: {
const MCFillFragment *FF = cast<MCFillFragment>(this); const MCFillFragment *FF = cast<MCFillFragment>(this);
OS << " Value:" << FF->getValue() << " Size:" << FF->getSize(); OS << " Value:" << static_cast<unsigned>(FF->getValue())
<< " Size:" << FF->getSize();
break; break;
} }
case MCFragment::FT_Relaxable: { case MCFragment::FT_Relaxable: {
const MCRelaxableFragment *F = cast<MCRelaxableFragment>(this); const MCRelaxableFragment *F = cast<MCRelaxableFragment>(this);
OS << "\n "; OS << "\n ";
OS << " Inst:"; OS << " Inst:";
F->getInst().dump_pretty(OS); F->getInst().dump_pretty(OS);
break; break;
} }
case MCFragment::FT_Org: { case MCFragment::FT_Org: {
const MCOrgFragment *OF = cast<MCOrgFragment>(this); const MCOrgFragment *OF = cast<MCOrgFragment>(this);
OS << "\n "; OS << "\n ";
OS << " Offset:" << OF->getOffset() << " Value:" << OF->getValue(); OS << " Offset:" << OF->getOffset()
<< " Value:" << static_cast<unsigned>(OF->getValue());
break; break;
} }
case MCFragment::FT_Dwarf: { case MCFragment::FT_Dwarf: {
const MCDwarfLineAddrFragment *OF = cast<MCDwarfLineAddrFragment>(this); const MCDwarfLineAddrFragment *OF = cast<MCDwarfLineAddrFragment>(this);
OS << "\n "; OS << "\n ";
OS << " AddrDelta:" << OF->getAddrDelta() OS << " AddrDelta:" << OF->getAddrDelta()
<< " LineDelta:" << OF->getLineDelta(); << " LineDelta:" << OF->getLineDelta();
break; break;
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines