Previously we didn't add debug info chunks to the SparseChunks array, so
they didn't participate in section GC. Now we do.
Details
Diff Detail
- Build Status
Buildable 7380 Build 7380: arc lint + arc unit
Event Timeline
lld/COFF/Chunks.h | ||
---|---|---|
182 | Since this function is not called very often, I'd remove the member variable and check the condition every time the function is called. |
lld/COFF/Chunks.h | ||
---|---|---|
182 | Isn't this function called by the Writer for every chunk written to the output file? |
lld/COFF/Chunks.h | ||
---|---|---|
182 | Even if it is, I think it is still negligible. |
lld/COFF/Chunks.h | ||
---|---|---|
183–184 | I'm sorry to be too picky, but isn't SectionName == ".debug" || SectionName.startswith(".debug$") enough? In LLD I'm really trying hard to make our code simple, boring and straightforward unless there's a strong reason to make it clever. |
lld/COFF/Chunks.h | ||
---|---|---|
183–184 | Sure, we can do that. I felt like if this was going to be on the main path, then we should at least try to be clever... |
Since this function is not called very often, I'd remove the member variable and check the condition every time the function is called.