This is an archive of the discontinued LLVM Phabricator instance.

Have writeCOFFWriter return Expected<unique_ptr>.
ClosedPublic

Authored by ecbeckmann on Jun 16 2017, 5:30 PM.

Details

Summary

Have writeCOFFWriter return Expected<unique_ptr> instead of requiring being passed an uninitialized unique_ptr.

Event Timeline

ecbeckmann created this revision.Jun 16 2017, 5:30 PM
ruiu added inline comments.Jun 16 2017, 5:54 PM
llvm/lib/Object/WindowsResource.cpp
312–313

Do you have to explicitly delete these copy ctors?

Removed deleted constructors.

ecbeckmann added inline comments.Jun 16 2017, 7:02 PM
llvm/lib/Object/WindowsResource.cpp
312–313

oh sorry, i meant to remove that

ruiu accepted this revision.Jun 16 2017, 7:12 PM

LGTM

This revision is now accepted and ready to land.Jun 16 2017, 7:12 PM
This revision was automatically updated to reflect the committed changes.