This is an archive of the discontinued LLVM Phabricator instance.

[PATCH] [PGO] Fixed cast operation in emIntrinsicVisitor::instrumentOneMemIntrinsic.
ClosedPublic

Authored by apazos on Jun 16 2017, 2:07 PM.

Reviewers

Commits

lgtm

This revision is now accepted and ready to land.Jun 18 2017, 9:25 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Instrumentation/

2 lines

test/

Transforms/

PGOProfile/

14 lines

Show First 20 Lines • Show All 1,171 Lines • ▼ Show 20 Lines	void MemIntrinsicVisitor::instrumentOneMemIntrinsic(MemIntrinsic &MI) {
IRBuilder<> Builder(&MI);		IRBuilder<> Builder(&MI);
Type *Int64Ty = Builder.getInt64Ty();		Type *Int64Ty = Builder.getInt64Ty();
Type *I8PtrTy = Builder.getInt8PtrTy();		Type *I8PtrTy = Builder.getInt8PtrTy();
Value *Length = MI.getLength();		Value *Length = MI.getLength();
assert(!dyn_cast<ConstantInt>(Length));		assert(!dyn_cast<ConstantInt>(Length));
Builder.CreateCall(		Builder.CreateCall(
Intrinsic::getDeclaration(M, Intrinsic::instrprof_value_profile),		Intrinsic::getDeclaration(M, Intrinsic::instrprof_value_profile),
{llvm::ConstantExpr::getBitCast(FuncNameVar, I8PtrTy),		{llvm::ConstantExpr::getBitCast(FuncNameVar, I8PtrTy),
Builder.getInt64(FuncHash), Builder.CreatePtrToInt(Length, Int64Ty),		Builder.getInt64(FuncHash), Builder.CreateZExtOrTrunc(Length, Int64Ty),
Builder.getInt32(IPVK_MemOPSize), Builder.getInt32(CurCtrId)});		Builder.getInt32(IPVK_MemOPSize), Builder.getInt32(CurCtrId)});
++CurCtrId;		++CurCtrId;
}		}

void MemIntrinsicVisitor::visitMemIntrinsic(MemIntrinsic &MI) {		void MemIntrinsicVisitor::visitMemIntrinsic(MemIntrinsic &MI) {
if (!PGOInstrMemOP)		if (!PGOInstrMemOP)
return;		return;
Value *Length = MI.getLength();		Value *Length = MI.getLength();
▲ Show 20 Lines • Show All 374 Lines • Show Last 20 Lines

				; RUN: opt < %s -pgo-instr-gen -S \| FileCheck %s

				declare void @llvm.memcpy.p0i8.p0i8.i32(i8* nocapture writeonly, i8* nocapture readonly, i32, i32, i1)
				declare i32 @strlen(i8* nocapture)

				; CHECK_LABEL: test
				; CHECK: %1 = zext i32 %c to i64
				; CHECK: call void @llvm.instrprof.value.profile(i8* getelementptr inbounds ([4 x i8], [4 x i8]* @__profn_test, i32 0, i32 0), i64 12884901887, i64 %1, i32 1, i32 0)

				define void @test(i8* %a, i8* %p) {
				%c = call i32 @strlen(i8* %p)
				call void @llvm.memcpy.p0i8.p0i8.i32(i8* %a, i8* %p, i32 %c, i32 1, i1 false)
				ret void
				}