This is an archive of the discontinued LLVM Phabricator instance.

[Dominators] Clean up GenericDomTree.h. NFC.
ClosedPublic

Authored by kuhar on Jun 14 2017, 5:57 PM.

Details

Summary

This patch cleans up GenericDomTree.h by:

  • removing unnecessary <NodeT> in DomTreeNodeBase
  • removing unnecessary std::move on bools
  • changing type of DFSNumIn/DFSNumOut from int to unsigned (since the members were used as unsigned anyway)

The changes don't affect behavior -- everything works as before.

Diff Detail

Repository
rL LLVM

Event Timeline

kuhar created this revision.Jun 14 2017, 5:57 PM
davide added a subscriber: davide.Jun 14 2017, 7:57 PM
dberlin accepted this revision.Jun 15 2017, 7:08 PM

Do you have commit access?

include/llvm/Support/GenericDomTree.h
103

I would just use ~0 or something

This revision is now accepted and ready to land.Jun 15 2017, 7:08 PM
kuhar updated this revision to Diff 102786.Jun 15 2017, 10:32 PM

static_cast<unsigned>(-1) --> ~0

kuhar marked an inline comment as done.Jun 15 2017, 10:33 PM

Do you have commit access?

Yes.

This revision was automatically updated to reflect the committed changes.