This is an archive of the discontinued LLVM Phabricator instance.

[clang] Cleanup fixit.c
ClosedPublic

Authored by alexander-shaposhnikov on Jun 9 2017, 2:46 PM.

Reviewers

mehdi_amini
arphaman

Commits

Summary

This diff removes temporary file t2 in fixit.c and updates the test command accordingly.
NFC.

Test plan:
make check-all

alexander-shaposhnikov edited the summary of this revision. (Show Details)

LGTM

This revision is now accepted and ready to land.Jun 9 2017, 3:11 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

test/

FixIt/

3 lines

	// RUN: %clang_cc1 -pedantic -Wunused-label -verify -x c %s			// RUN: %clang_cc1 -pedantic -Wunused-label -verify -x c %s
	// RUN: cp %s %t			// RUN: cp %s %t
	// RUN: not %clang_cc1 -pedantic -Wunused-label -fixit -x c %t			// RUN: not %clang_cc1 -pedantic -Wunused-label -fixit -x c %t
	// RUN: grep -v CHECK %t > %t2
	// RUN: %clang_cc1 -pedantic -Wunused-label -Werror -x c %t			// RUN: %clang_cc1 -pedantic -Wunused-label -Werror -x c %t
	// RUN: FileCheck -input-file=%t2 %t			// RUN: grep -v CHECK %t \| FileCheck %t

	/* This is a test of the various code modification hints that are			/* This is a test of the various code modification hints that are
	provided as part of warning or extension diagnostics. All of the			provided as part of warning or extension diagnostics. All of the
	warnings will be fixed by -fixit, and the resulting file should			warnings will be fixed by -fixit, and the resulting file should
	compile cleanly with -Werror -pedantic. */			compile cleanly with -Werror -pedantic. */

	// FIXME: FIX-IT should add #include <string.h>?			// FIXME: FIX-IT should add #include <string.h>?
	int strcmp(const char s1, const char s2);			int strcmp(const char s1, const char s2);
	▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines