This is an archive of the discontinued LLVM Phabricator instance.

Repair 2010-05-31-palignr.c test
ClosedPublic

Authored by teemperor on Jun 8 2017, 1:07 AM.

Details

Reviewers
echristo
Summary

This test was silently failing since a long time because it failed to include stdlib.h (as it's running in a freestanding environment). However, because we used just not clang_cc1 instead of the verify mode, this regression was never noticed and the test was just always passing.

This adds -ffreestanding to the invocation, so that tmmintrin.h doesn't indirectly include mm_malloc.h, which in turns includes the unavailable stdlib.h. We also run now in the -verify mode to prevent that we silently regress again.

I've also updated the test to no longer check the return value of _mm_alignr_epi8 as this is also causing it to fail (and it's not really the job of this test to test this).

Diff Detail

Event Timeline

teemperor created this revision.Jun 8 2017, 1:07 AM
teemperor added a reviewer: echristo.
teemperor removed a subscriber: echristo.
echristo accepted this revision.Jun 8 2017, 1:03 PM

Thanks for the fix!

Do you need someone to commit it?

This revision is now accepted and ready to land.Jun 8 2017, 1:03 PM

Raphael and I work together I can take care of it...

v.g.vassilev closed this revision.Jun 9 2017, 9:43 AM

Landed in r305089.