This is an archive of the discontinued LLVM Phabricator instance.

Differential D33986

[ELF] - Simplify gdb-index-empty.s
ClosedPublic

Authored by grimar on Jun 7 2017, 5:30 AM.

Details

Reviewers
ruiu
• rafael
pcc
Commits
rGadaba7aeaa1e: [ELF] - Simplify gdb-index-empty.s
rLLD305073: [ELF] - Simplify gdb-index-empty.s
rL305073: [ELF] - Simplify gdb-index-empty.s
Summary

Just like I mentioned in post commit review for D33176,
this can be simplified.

May be it is possible to simplify even more,
I only tried to apply obvious simplification
changes I already did for other .gdb_index patches I worked on.

(faced with this testcase today during work on another patch and decided to
improve it while I am here).

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Jun 7 2017, 5:30 AM
Herald added a subscriber: emaste. · View Herald TranscriptJun 7 2017, 5:30 AM
Closed by commit rL305073: [ELF] - Simplify gdb-index-empty.s (authored by grimar). · Explain WhyJun 9 2017, 6:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
test/
ELF/
168 lines

Diff 102023

lld/trunk/test/ELF/gdb-index-empty.s

# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux -o %t %s # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux -o %t %s
# RUN: ld.lld --gdb-index --gc-sections -o %t2 %t # RUN: ld.lld --gdb-index --gc-sections -o %t2 %t
# RUN: llvm-dwarfdump -debug-dump=gdb_index %t2 | FileCheck %s # RUN: llvm-dwarfdump -debug-dump=gdb_index %t2 | FileCheck %s
# CHECK: Address area offset = 0x28, has 0 entries: # CHECK: Address area offset = 0x28, has 0 entries:
# Generated with: (clang r302976) # Generated with: (clang r302976)
# echo "void _start() { __builtin_unreachable(); }" | \ # echo "void _start() { __builtin_unreachable(); }" | \
# clang -Os -g -S -o gdb-index-empty.s -x c - -Xclang -fdebug-compilation-dir -Xclang . # clang -Os -g -S -o gdb-index-empty.s -x c - -Xclang -fdebug-compilation-dir -Xclang .
.text .text
.file "-"
.globl _start .globl _start
.type _start,@function .type _start,@function
_start: # @_start _start:
.Lfunc_begin0: .Lfunc_begin0:
.cfi_startproc
# BB#0: # %entry
.Lfunc_end0: .Lfunc_end0:
.size _start, .Lfunc_end0-_start
.cfi_endproc
.file 1 "<stdin>"
.section .debug_str,"MS",@progbits,1
.Linfo_string0:
.asciz "clang version 5.0.0 " # string offset=0
.Linfo_string1:
.asciz "-" # string offset=21
.Linfo_string2:
.asciz "." # string offset=23
.Linfo_string3:
.asciz "_start" # string offset=25
.section .debug_loc,"",@progbits
.section .debug_abbrev,"",@progbits .section .debug_abbrev,"",@progbits
.byte 1 # Abbreviation Code .byte 1 # Abbreviation Code
.byte 17 # DW_TAG_compile_unit .byte 17 # DW_TAG_compile_unit
.byte 1 # DW_CHILDREN_yes .byte 1 # DW_CHILDREN_yes
.byte 37 # DW_AT_producer .byte 37 # DW_AT_producer
.byte 14 # DW_FORM_strp .byte 14 # DW_FORM_strp
.byte 19 # DW_AT_language .byte 19 # DW_AT_language
.byte 5 # DW_FORM_data2 .byte 5 # DW_FORM_data2
.byte 3 # DW_AT_name .byte 3 # DW_AT_name
.byte 14 # DW_FORM_strp .byte 14 # DW_FORM_strp
.byte 16 # DW_AT_stmt_list .byte 16 # DW_AT_stmt_list
.byte 23 # DW_FORM_sec_offset .byte 23 # DW_FORM_sec_offset
.byte 27 # DW_AT_comp_dir .byte 27 # DW_AT_comp_dir
.byte 14 # DW_FORM_strp .byte 14 # DW_FORM_strp
.byte 17 # DW_AT_low_pc .byte 17 # DW_AT_low_pc
.byte 1 # DW_FORM_addr .byte 1 # DW_FORM_addr
.byte 18 # DW_AT_high_pc .byte 18 # DW_AT_high_pc
.byte 6 # DW_FORM_data4 .byte 6 # DW_FORM_data4
.byte 0 # EOM(1) .byte 0 # EOM(1)
.byte 0 # EOM(2) .byte 0 # EOM(2)
.byte 2 # Abbreviation Code .byte 2 # Abbreviation Code
.byte 46 # DW_TAG_subprogram .byte 46 # DW_TAG_subprogram
.byte 0 # DW_CHILDREN_no .byte 0 # DW_CHILDREN_no
.byte 17 # DW_AT_low_pc .byte 17 # DW_AT_low_pc
.byte 1 # DW_FORM_addr .byte 1 # DW_FORM_addr
.byte 18 # DW_AT_high_pc .byte 18 # DW_AT_high_pc
.byte 6 # DW_FORM_data4 .byte 6 # DW_FORM_data4
.byte 64 # DW_AT_frame_base .byte 64 # DW_AT_frame_base
.byte 24 # DW_FORM_exprloc .byte 24 # DW_FORM_exprloc
.byte 3 # DW_AT_name .byte 3 # DW_AT_name
.byte 14 # DW_FORM_strp .byte 14 # DW_FORM_strp
.byte 58 # DW_AT_decl_file .byte 58 # DW_AT_decl_file
.byte 11 # DW_FORM_data1 .byte 11 # DW_FORM_data1
.byte 59 # DW_AT_decl_line .byte 59 # DW_AT_decl_line
.byte 11 # DW_FORM_data1 .byte 11 # DW_FORM_data1
.byte 63 # DW_AT_external .byte 63 # DW_AT_external
.byte 25 # DW_FORM_flag_present .byte 25 # DW_FORM_flag_present
.byte 0 # EOM(1) .byte 0 # EOM(1)
.byte 0 # EOM(2) .byte 0 # EOM(2)
.byte 0 # EOM(3) .byte 0 # EOM(3)
.section .debug_info,"",@progbits .section .debug_info,"",@progbits
.Lcu_begin0:
.long 60 # Length of Unit .long 60 # Length of Unit
.short 4 # DWARF version number .short 4 # DWARF version number
.long .debug_abbrev # Offset Into Abbrev. Section .long .debug_abbrev # Offset Into Abbrev. Section
.byte 8 # Address Size (in bytes) .byte 8 # Address Size (in bytes)
.byte 1 # Abbrev [1] 0xb:0x35 DW_TAG_compile_unit .byte 1 # Abbrev [1] 0xb:0x35 DW_TAG_compile_unit
.long .Linfo_string0 # DW_AT_producer .long 0 # DW_AT_producer
.short 12 # DW_AT_language .short 12 # DW_AT_language
.long .Linfo_string1 # DW_AT_name .long 0 # DW_AT_name
.long .Lline_table_start0 # DW_AT_stmt_list .long 0 # DW_AT_stmt_list
.long .Linfo_string2 # DW_AT_comp_dir .long 0 # DW_AT_comp_dir
.quad .Lfunc_begin0 # DW_AT_low_pc .quad .Lfunc_begin0 # DW_AT_low_pc
.long .Lfunc_end0-.Lfunc_begin0 # DW_AT_high_pc .long .Lfunc_end0-.Lfunc_begin0 # DW_AT_high_pc
.byte 2 # Abbrev [2] 0x2a:0x15 DW_TAG_subprogram .byte 2 # Abbrev [2] 0x2a:0x15 DW_TAG_subprogram
.quad .Lfunc_begin0 # DW_AT_low_pc .quad .Lfunc_begin0 # DW_AT_low_pc
.long .Lfunc_end0-.Lfunc_begin0 # DW_AT_high_pc .long .Lfunc_end0-.Lfunc_begin0 # DW_AT_high_pc
.byte 1 # DW_AT_frame_base .byte 1 # DW_AT_frame_base
.byte 87 .byte 87
.long .Linfo_string3 # DW_AT_name .long 0 # DW_AT_name
.byte 1 # DW_AT_decl_file .byte 1 # DW_AT_decl_file
.byte 1 # DW_AT_decl_line .byte 1 # DW_AT_decl_line
# DW_AT_external
.byte 0 # End Of Children Mark .byte 0 # End Of Children Mark
.section .debug_ranges,"",@progbits
.section .debug_macinfo,"",@progbits
.Lcu_macro_begin0:
.byte 0 # End Of Macro List Mark
.section .debug_pubnames,"",@progbits
.long .LpubNames_end0-.LpubNames_begin0 # Length of Public Names Info
.LpubNames_begin0:
.short 2 # DWARF Version
.long .Lcu_begin0 # Offset of Compilation Unit Info
.long 64 # Compilation Unit Length
.long 42 # DIE offset
.asciz "_start" # External Name
.long 0 # End Mark
.LpubNames_end0:
.ident "clang version 5.0.0 "
.section ".note.GNU-stack","",@progbits
.section .debug_line,"",@progbits
.Lline_table_start0: