Introduce the new feature "abi-breaking-checks"

[chapuni]

Summary

A few tests in llvm/test/Transforms/Util/PredicateInfo/ are using -reverse-iterate.
The option -reverse-iterate is enabled with +Asserts in usual cases, but it can be turned on/off regardless of LLVM_ENABLE_ASSERTIONS.

I think it is better to introduce the new feature "abi-breaking-checks" for that.

[mgrang]

LGTM.

[mgrang]

Accepting the patch, unless @chandlerc has any concerns/comments.

[mgrang]

@chapuni I see that your patch is on llvm/trunk. Do you intend to push it to llvm master as well?

[chapuni]

I wonder D33908 might break assumptions.

In D33854#774567, @mgrang wrote:

@chapuni I see that your patch is on llvm/trunk. Do you intend to push it to llvm master as well?

llvm/trunk is just path in the diff.

[mgrang]

Can you commit this patch? I tried committing but got errors:
error: llvm/trunk/test/lit.site.cfg.in: does not exist in index
error: llvm/trunk/test/lit.cfg: does not exist in index
error: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll: does not exist in index
error: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll: does not exist in index

[chapuni]

In D33854#774585, @mgrang wrote:

Can you commit this patch? I tried committing but got errors:
error: llvm/trunk/test/lit.site.cfg.in: does not exist in index
error: llvm/trunk/test/lit.cfg: does not exist in index
error: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll: does not exist in index
error: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll: does not exist in index

Excuse me, I didn't use arc in my daily tasks.

[mgrang]

In D33854#774597, @chapuni wrote:

In D33854#774585, @mgrang wrote:

Can you commit this patch? I tried committing but got errors:
error: llvm/trunk/test/lit.site.cfg.in: does not exist in index
error: llvm/trunk/test/lit.cfg: does not exist in index
error: llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll: does not exist in index
error: llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll: does not exist in index

Excuse me, I didn't use arc in my daily tasks.

Thanks for this patch!

llvm/trunk/test/Transforms/Util/PredicateInfo/condprop2.ll

-; REQUIRES: asserts
+; REQUIRES: abi-breaking-checks
 ; NOTE: The flag -reverse-iterate is present only in a +Asserts build.
 ; Hence, this test has been split from condprop.ll to test with -reverse-iterate.
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt -print-predicateinfo -analyze -reverse-iterate  < %s 2>&1 | FileCheck %s
 
 @a = external global i32    ; <i32*> [#uses=7]
 
 define i32 @test1() nounwind {

llvm/trunk/test/Transforms/Util/PredicateInfo/testandor2.ll

-; REQUIRES: asserts
+; REQUIRES: abi-breaking-checks
 ; NOTE: The flag -reverse-iterate is present only in a +Asserts build.
 ; Hence, this test has been split from testandor.ll to test with -reverse-iterate.
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt -print-predicateinfo -reverse-iterate < %s 2>&1 | FileCheck %s
 
 declare void @foo(i1)
 declare void @bar(i32)
 declare void @llvm.assume(i1)

llvm/trunk/test/lit.cfg

except OSError:
     exit(42)
 
 if re.search(r'ON', llvm_config_cmd.stdout.read().decode('ascii')):
     config.available_features.add('global-isel')
 llvm_config_cmd.wait()
 
 if config.have_libxar:
     config.available_features.add('xar')
+
+if config.enable_abi_breaking_checks == "1":
+    config.available_features.add('abi-breaking-checks')

llvm/trunk/test/lit.site.cfg.in

 config.ocamlfind_executable = "@OCAMLFIND@"
 config.have_ocamlopt = @HAVE_OCAMLOPT@
 config.have_ocaml_ounit = @HAVE_OCAML_OUNIT@
 config.ocaml_flags = "@OCAMLFLAGS@"
 config.include_go_tests = @LLVM_INCLUDE_GO_TESTS@
 config.go_executable = "@GO_EXECUTABLE@"
 config.enable_shared = @ENABLE_SHARED@
 config.enable_assertions = @ENABLE_ASSERTIONS@
+config.enable_abi_breaking_checks = "@LLVM_ENABLE_ABI_BREAKING_CHECKS@"
 config.targets_to_build = "@TARGETS_TO_BUILD@"
 config.native_target = "@LLVM_NATIVE_ARCH@"
 config.llvm_bindings = "@LLVM_BINDINGS@".split(' ')
 config.host_os = "@HOST_OS@"
 config.host_arch = "@HOST_ARCH@"
 config.host_cc = "@HOST_CC@"
 config.host_cxx = "@HOST_CXX@"
 config.host_ldflags = "@HOST_LDFLAGS@"