This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Do not crash when proccessing absolute symbols during GC.
ClosedPublic

Authored by grimar on May 31 2017, 1:45 AM.

Reviewers

ruiu
• rafael

Commits

Summary

This is PR33239, previously we segfault on given testcase.

Thanks!

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

trunk/

ELF/

3 lines

test/

ELF/

7 lines

Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Lines	auto Enqueue = [&](ResolvedReloc R) {
R.Sec->Live = true;		R.Sec->Live = true;
// Add input section to the queue.		// Add input section to the queue.
if (InputSection *S = dyn_cast<InputSection>(R.Sec))		if (InputSection *S = dyn_cast<InputSection>(R.Sec))
Q.push_back(S);		Q.push_back(S);
};		};

auto MarkSymbol = [&](const SymbolBody *Sym) {		auto MarkSymbol = [&](const SymbolBody *Sym) {
if (auto *D = dyn_cast_or_null<DefinedRegular>(Sym))		if (auto *D = dyn_cast_or_null<DefinedRegular>(Sym))
Enqueue({cast<InputSectionBase>(D->Section), D->Value});		if (auto *IS = cast_or_null<InputSectionBase>(D->Section))
		Enqueue({IS, D->Value});
};		};

// Add GC root symbols.		// Add GC root symbols.
MarkSymbol(Symtab<ELFT>::X->find(Config->Entry));		MarkSymbol(Symtab<ELFT>::X->find(Config->Entry));
MarkSymbol(Symtab<ELFT>::X->find(Config->Init));		MarkSymbol(Symtab<ELFT>::X->find(Config->Init));
MarkSymbol(Symtab<ELFT>::X->find(Config->Fini));		MarkSymbol(Symtab<ELFT>::X->find(Config->Fini));
for (StringRef S : Config->Undefined)		for (StringRef S : Config->Undefined)
MarkSymbol(Symtab<ELFT>::X->find(S));		MarkSymbol(Symtab<ELFT>::X->find(S));
Show All 34 Lines

				# REQUIRES: x86

				# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
				# RUN: ld.lld %t -o %t2 -shared --gc-sections

				.global foo
				foo = 0x123