[coroutines] Call initializePass in coroutine pass constructors

[GorNishanov]

Summary

Fixes: https://bugs.llvm.org/show_bug.cgi?id=33226

[davide]

I thought there was a way to test skipFunction() ? See Andrew Kaylor's first series of opt-bisect-limit=/opt-bisection support.

[GorNishanov]

In D33701#768335, @davide wrote:

I thought there was a way to test skipFunction() ? See Andrew Kaylor's first series of opt-bisect-limit=/opt-bisection support.

Hmm... Reading more on opt-bisect-limit, I think it is incorrect to use skipFunction in coroutine passes. Coroutine passes can not be safely skipped while still allowing correct code generation. I am taking skipFunction checks out

[GorNishanov]

remove skipFunction check as it is inappropriate for coroutine passes

[chandlerc]

The missing initialize calls seem good to fix as-is, so LGTM for that.

lib/Transforms/Coroutines/CoroCleanup.cpp

 //                              Top Level Driver
 //===----------------------------------------------------------------------===//
 
 namespace {
 
 struct CoroCleanup : FunctionPass {
   static char ID; // Pass identification, replacement for typeid
 
-  CoroCleanup() : FunctionPass(ID) {}
+  CoroCleanup() : FunctionPass(ID) {
+    initializeCoroCleanupPass(*PassRegistry::getPassRegistry());
+  }
 
   std::unique_ptr<Lowerer> L;
 
   // This pass has work to do only if we find intrinsics we are going to lower
   // in the module.
   bool doInitialization(Module &M) override {
     if (coro::declaresIntrinsics(M, {"llvm.coro.alloc", "llvm.coro.begin",
                                      "llvm.coro.subfn.addr", "llvm.coro.free",

lib/Transforms/Coroutines/CoroEarly.cpp

 //===----------------------------------------------------------------------===//
 //                              Top Level Driver
 //===----------------------------------------------------------------------===//
 
 namespace {
 
 struct CoroEarly : public FunctionPass {
   static char ID; // Pass identification, replacement for typeid.
-  CoroEarly() : FunctionPass(ID) {}
+  CoroEarly() : FunctionPass(ID) {
+    initializeCoroEarlyPass(*PassRegistry::getPassRegistry());
+  }
 
   std::unique_ptr<Lowerer> L;
 
   // This pass has work to do only if we find intrinsics we are going to lower
   // in the module.
   bool doInitialization(Module &M) override {
     if (coro::declaresIntrinsics(M, {"llvm.coro.id", "llvm.coro.destroy",
                                      "llvm.coro.done", "llvm.coro.end",

lib/Transforms/Coroutines/CoroElide.cpp

 
 //===----------------------------------------------------------------------===//
 //                              Top Level Driver
 //===----------------------------------------------------------------------===//
 
 namespace {
 struct CoroElide : FunctionPass {
   static char ID;
-  CoroElide() : FunctionPass(ID) {}
+  CoroElide() : FunctionPass(ID) {
+    initializeCoroElidePass(*PassRegistry::getPassRegistry());
+  }
 
   std::unique_ptr<Lowerer> L;
 
   bool doInitialization(Module &M) override {
     if (coro::declaresIntrinsics(M, {"llvm.coro.id"}))
       L = llvm::make_unique<Lowerer>(M);
     return false;
   }

lib/Transforms/Coroutines/CoroSplit.cpp

 //===----------------------------------------------------------------------===//
 //                              Top Level Driver
 //===----------------------------------------------------------------------===//
 
 namespace {
 
 struct CoroSplit : public CallGraphSCCPass {
   static char ID; // Pass identification, replacement for typeid
-  CoroSplit() : CallGraphSCCPass(ID) {}
+  CoroSplit() : CallGraphSCCPass(ID) {
+    initializeCoroSplitPass(*PassRegistry::getPassRegistry());
+  }
 
   bool Run = false;
 
   // A coroutine is identified by the presence of coro.begin intrinsic, if
   // we don't have any, this pass has nothing to do.
   bool doInitialization(CallGraph &CG) override {
     Run = coro::declaresIntrinsics(CG.getModule(), {"llvm.coro.begin"});
     return CallGraphSCCPass::doInitialization(CG);