This is an archive of the discontinued LLVM Phabricator instance.

[coroutines] Call initializePass in coroutine pass constructors
ClosedPublic

Authored by GorNishanov on May 30 2017, 4:08 PM.

Diff Detail

Event Timeline

GorNishanov created this revision.May 30 2017, 4:08 PM
davide edited edge metadata.May 30 2017, 4:37 PM

I thought there was a way to test skipFunction() ? See Andrew Kaylor's first series of opt-bisect-limit=/opt-bisection support.

I thought there was a way to test skipFunction() ? See Andrew Kaylor's first series of opt-bisect-limit=/opt-bisection support.

Hmm... Reading more on opt-bisect-limit, I think it is incorrect to use skipFunction in coroutine passes. Coroutine passes can not be safely skipped while still allowing correct code generation. I am taking skipFunction checks out

GorNishanov edited the summary of this revision. (Show Details)

remove skipFunction check as it is inappropriate for coroutine passes

chandlerc accepted this revision.May 30 2017, 7:18 PM

The missing initialize calls seem good to fix as-is, so LGTM for that.

This revision is now accepted and ready to land.May 30 2017, 7:18 PM
This revision was automatically updated to reflect the committed changes.