AntiDepBreaker intends to add all live-outs, including the implicit
CSRs, in StartBlock. r299124 was done without understanding that
intention.
Now with the live-ins propagated correctly (D32464), we can revert this change.
Paths
| Differential D33697
[AntiDepBreaker] Revert r299124 and add a test. ClosedPublic Authored by timshen on May 30 2017, 3:04 PM.
Details Summary AntiDepBreaker intends to add all live-outs, including the implicit Now with the live-ins propagated correctly (D32464), we can revert this change.
Diff Detail
Event TimelineComment Actions LGTM. The test feels like a longer more complicated version of livephysregs.mir to me now (as it just checks for livein lists as well), but keep it if you think it helps. This revision is now accepted and ready to land.May 30 2017, 3:08 PM Comment Actions
Oh I didn't realize that you already have a more reduced test case from it - I'll remove mine, in the hope to reduce maintenance burden (e.g. names like bb.2.if.then) in the future. Closed by commit rL304251: [AntiDepBreaker] Revert r299124 and add a test. (authored by timshen). · Explain WhyMay 30 2017, 3:27 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 100785 llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp
llvm/lib/CodeGen/CriticalAntiDepBreaker.cpp
llvm/test/CodeGen/PowerPC/if-converter-split-liveins.ll
llvm/test/CodeGen/PowerPC/pristine-and-livein.mir
|