This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Filter out non InputSection members from InputSections
ClosedPublic

Authored by phosek on May 28 2017, 1:25 AM.

Reviewers

Commits

Summary

InputSections may contain MergeInputSection members which trigger a segmentation fault when trying to cast them to InputSection.

LGTM

This revision is now accepted and ready to land.May 28 2017, 1:55 AM

Can you add a test

Added a test case.

This revision was automatically updated to reflect the committed changes.

Path

Size

ELF/

3 lines

	Show First 20 Lines • Show All 284 Lines • ▼ Show 20 Lines
	LinkerScript::computeInputSections(const InputSectionDescription *Cmd) {			LinkerScript::computeInputSections(const InputSectionDescription *Cmd) {
	std::vector<InputSection *> Ret;			std::vector<InputSection *> Ret;

	// Collects all sections that satisfy constraints of Cmd.			// Collects all sections that satisfy constraints of Cmd.
	for (const SectionPattern &Pat : Cmd->SectionPatterns) {			for (const SectionPattern &Pat : Cmd->SectionPatterns) {
	size_t SizeBefore = Ret.size();			size_t SizeBefore = Ret.size();

	for (InputSectionBase *Sec : InputSections) {			for (InputSectionBase *Sec : InputSections) {
				if (!isa<InputSection>(Sec))
				continue;

	if (Sec->Assigned)			if (Sec->Assigned)
	continue;			continue;

	// For -emit-relocs we have to ignore entries like			// For -emit-relocs we have to ignore entries like
	// .rela.dyn : { *(.rela.data) }			// .rela.dyn : { *(.rela.data) }
	// which are common because they are in the default bfd script.			// which are common because they are in the default bfd script.
	if (Sec->Type == SHT_REL \|\| Sec->Type == SHT_RELA)			if (Sec->Type == SHT_REL \|\| Sec->Type == SHT_RELA)
	continue;			continue;
	▲ Show 20 Lines • Show All 856 Lines • Show Last 20 Lines